kids-first / kf-uikit

🎨 Design System for Kids First
https://kf-uikit.netlify.com
Apache License 2.0
1 stars 1 forks source link

Temp/percy test #104

Closed bdolly closed 5 years ago

bdolly commented 5 years ago

Motivation

Why are you creating this PR? What does is solve? Include links to relevent Github issues and other resources.

Use Cases

In order for a component to be merged into the design system it must have a minimum of three separate use cases or two plausible future buisness cases. Please include any relevant contextual information and screenshots showing these use cases or implementation discrepencies this component resolves.

1.

2.

3.

API changes

Are you making any API changes? Did you create a separate PR first to change the docs and approve the changes?

Implementation Notes

Anything that could be helpful to the reviewer. Especially if it not obvious from looking at the diffs.

Rendering and Storybook location

In order to keep design and development in-sync each component must new component must follow the folder structure below

src/
└── components
    ├── Button
    │   ├── __tests__/
    │   ├── Button.jsx
    │   ├── Button.story.jsx
    │   └── Button.css
    └── index.js

Functional Tests

You should functionally test your changes. Can you list the cases you tested?

dankolbman commented 5 years ago

UIKit Storybook for Review

Built with commit c425ef6eb4024f1331a59fe81d55f305b5dff18b

https://deploy-preview-104--kf-uikit.netlify.com