search

kids-first / kf-uikit

🎨 Design System for Kids First
https://kf-uikit.netlify.com
Apache License 2.0
1 stars 1 forks source link

🐛 Bug/113 header styling corrections #114

Closed bdolly closed 5 years ago

bdolly commented 5 years ago

Addresses #113

Somewhere along the line the header styles broke, i.e. way off from the previous production uikit release 0.3.1 and they were not caught before they were merged to master.

🕵️ the cause is likely due to major changes to the spacing system introduced in #87, when it was merged regression testing wasn't in place

This PR seeks to correct this by reverting some of the styles to their old values and leveraging the new spacing system to normalize padding and margins in the Header component.

❗️ any other changes to the Header outside of corrections should be addressed with a new PR using the PR template

dankolbman commented 5 years ago

UIKit Storybook for Review

Built with commit 176a0ad05b39c0aa36359b0d6a2289ee901af3b4

https://deploy-preview-114--kf-uikit.netlify.com