🔧 use STORYBOOK_PERCY_ENV for yarn snapshot

kids-first / kf-uikit

🎨 Design System for Kids First

https://kf-uikit.netlify.com

Apache License 2.0

1 stars 1 forks source link

🔧 use STORYBOOK_PERCY_ENV for yarn snapshot #127

Closed bdolly closed 5 years ago

bdolly commented 5 years ago

This is a flag that is used to only render Percy specifc markup when storybook is built for percy consumption. This helps performance in the main storbook build

This is just a quick fix, a better solution in the future would be a custom storybook decorator that takes a param with the test markup and checks the env vars

dankolbman commented 5 years ago

UIKit Storybook for Review

Built with commit 327626daa2f9ef66f5184bd2e6d99da8d1cb74bc

https://deploy-preview-127--kf-uikit.netlify.com

bdolly commented 5 years ago

ok if you checkout the deploy preview and search the source for show-in-tests it shouldn't show up but all the proper snapshots are in percy