search

kidwm / brackets-response

Responsive design tool for Brackets
49 stars 7 forks source link

No scrollbars and other issues #5

Open 1951FDG opened 10 years ago

1951FDG commented 10 years ago

no scrollbars for either the preview or edit view. Also on enable the the responsive mode, the sidebar does not hide automatically.

Also should or does the inspect mode work correctly if the DOM is changed by javascript on document load?

Ruler (css) is always on top, for example, it overlays the extension pane.

kidwm commented 10 years ago

It has no scrollbars by original design. You can hide sidebar by yourself. Maybe I will change these behaviors in future versions.

I don't think so, the DOM may not be able to map the source code in editor.

But when you enter responsive mode, extension pane should be hidden, right?

1951FDG commented 10 years ago

Ok. minimal overlay scrollbars would be nice.

True, if DOM is changed, the inspect mode will not work properly.

Yes, extension pane should be hidden, but then again take a look at this screenshot:

lll

(I am using an extension which makes the extension panel bigger)

The ruler being on top of the panel, could be considered an aesthetic issue. But note that the scrollbar also disappears for the extension panel, as well as the sidebar, and this remains the same even when the response extension is no longer used. I consider this an issue.

kidwm commented 10 years ago

Yes, you're right, it should be an issue. The CSS file of this extension is still in a mess, and it has some rules which overwrite styles of Brackets. (BTW, in original version, this extension even did not have a function for exiting responsive mode.)

After rewriting the style structure, all these glitches should be fixed.

I'll open another issue for styles. Let this issue focus on scrollbars.

1951FDG commented 10 years ago

Ok. So from my understanding, the original author stopped development? Thank you for continuing development on this particular extension (in my opinion, it should have been officially integrated into Brackets, due to its usefulness)

kidwm commented 10 years ago

Yes, you can see his article: http://www.leebrimelow.com/responsive-brackets-extension-on-github/

It's my pleasure to present this awesome work of original author to community again. If we could make it keep evolving with Brackets, maybe that would happen someday in the future.

tenten71 commented 10 years ago

First, let me start off by saying thank you, thank you, thank you for continuing to develop this extension. I've been dying for it since I started using Brackets with release 39 (I'm currently using 44).

The scrollbar issue does suck but you can still use mouse wheel. I use a tablet, so I have to use my tablet wheel - which sucks.

However, I did go in and played around with your CSS. I commented out line 330...

::-webkit-scrollbar { /* display: none !important; */ }

...and line 334...

.CodeMirror-vscrollbar, .CodeMirror-hscrollbar { /* display: none !important; */ }

... and line 577...

.CodeMirror-vscrollbar > div { /* display: none !important; */ }

Now I get all my scrollbars back but I find that Responsive only works well in Vertical-Split mode and not so well in Horizontal-Split mode. The scrollbars don't work correctly and Inspect mode doesn't seem to scroll the content properly. But everything seems fine in Vertical mode.

I also find that after I turn off the Response panel, I lose my scrollbars again and I have to F5 Brackets to get them back.

So I can still use this tool and I'm glad about that. But I look forward to future updates for possible fixes.

Thanks again.

kidwm commented 10 years ago

@tenten71 Thanks for your appreciation.

I'll revamp CSS as soon as possible.

ikbenben commented 9 years ago

this should be working now in the original repository. the extension is called "Response for Brackets - original" in the extension manager. Install that instead of the one uploaded by kidwm

1951FDG commented 9 years ago

@ikbenben thanks for the heads up!

scrollbars work now in the "Response for Brackets - original" by @ikbenben

@kidwm, what will happen to this extension, now that changes have been merged into the original extension?

kidwm commented 9 years ago

@1951FDG I'll try to take it to another direction.

ikbenben commented 9 years ago

@kidwm, how come? why not work on it together on a single code base?

kidwm commented 9 years ago

@ikbenben I don't like the original flavor so much.

ikbenben commented 9 years ago

Can you outline your thoughts and what direction you want to take it? Maybe they still line up

kidwm commented 9 years ago

@ikbenben move it out of this editor.

ikbenben commented 9 years ago

You mean to stop using brackets all together?

kidwm commented 9 years ago

@ikbenben Maybe not.

ikbenben commented 9 years ago

@kidwm , you seem to be a man of many words ;)

I know English is not your first language but can you give a full detailed description of what you are thinking to see if they align to other thoughts that are out there?

One thought I have, which may be in the same line of what you are thinking is to have the option of having the responsive feature available in Live Edit Preview mode.

Maybe this is what you mean. I don't know because you seem to be unwilling to come forward with your thoughts

tenten71 commented 9 years ago

@ikbenben, thanks for this "original" version. The scrollbar issue does seem to be gone.

But there's a whole bunch of other bugs... Vertical Layout is still the best option. But this refresh button (curved arrow) appears (twice) and does nothing. The extension wants to use Horizontal Layout as default. I can't turn off the extension with the sidebar icon. There's overlapping going on. Sometimes the sidebar icons are missing. Kind of a mess. I've gone back to the other version.

ikbenben commented 9 years ago

@tenten71 , I've created an issue for this at https://github.com/brimelow/Response-for-Brackets/issues/51 as I was able to reproduce your vertical layout issues with the refresh button. Looks like some CSS layout issues which will be easy enough to address.

I do not have enough information for your other issues so if you have other issues (which are listed here but I'm not sure I understand), then can you create issues in detail over at https://github.com/brimelow/Response-for-Brackets/ including screenshots and steps to reproduce.

I'm actively working on the plugin over there so you will see fixes happening there

ikbenben commented 9 years ago

@tenten71 , i think your other issue is related to https://github.com/brimelow/Response-for-Brackets/issues/52. Can you confirm in that ticket if this is what you are experiencing.

tenten71 commented 9 years ago

All better now thanks to what you did in #52.