kieferk / dfply

dplyr-style piping operations for pandas dataframes
GNU General Public License v3.0
889 stars 103 forks source link

Write migration tutorial #32

Open Make42 opened 6 years ago

Make42 commented 6 years ago

On my development machine I installed dfply version 0.2.4. Now I installed dfply with pip install dfply on the server and suddenly I got NameError: name 'groupby' is not defined. It took me ages to realise it's not that code that is wrong, but you had a new release (which was such a surprise because it had been a while). It seems that your groupby is now group_by... maybe you can write a migration tutorial? Tensorflow did it reasonably well.

kieferk commented 6 years ago

Yes I changed the grouby to be group_by to mirror the dplyr function. Apologies for the code-breaking change. One way to resolve this in your code is to have an from dfply.group import group_by as groupby.

Given that is the only function name that changed between v2 and v3 (as far as I recall) a migration tutorial wouldn't have anything in it except that, but I will add something at the top of the readme to notify people.

Make42 commented 6 years ago

Thank you very much!

Also thank you very much for continuing development! It it much appreciated.

Make42 commented 6 years ago

The code examples in the README.md are still on groupby - once again I got confused when reading the examples... ;-)