kieferk / dfply

dplyr-style piping operations for pandas dataframes
GNU General Public License v3.0
890 stars 103 forks source link

commented out print statement in unite function #73

Closed jonvitale closed 5 years ago

jonvitale commented 6 years ago

I don't think this print is necessary

TariqAHassan commented 6 years ago

@jonvitale

If you think the code is not needed, then it would probably be best to go ahead and request it

a. be removed or b. only occur if in 'verbose mode', e.g.

if verbose:
     print(...)

For what it's worth, I agree with you but we'll have to see what kieferk thinks.

jonvitale commented 6 years ago

Isn't the point of a pull request, from my own fork where I commented it out, to do (a)?

kieferk commented 5 years ago

Cool, merged.