kieferk / dfply

dplyr-style piping operations for pandas dataframes
GNU General Public License v3.0
889 stars 103 forks source link

get_join_parameters has a bug: 'right_in' should be 'right_on' #74

Open jlaird-espresso opened 5 years ago

jlaird-espresso commented 5 years ago

The function get_join_parameters in join.py has an error:

        if not isinstance(by[0], str):
            left_on = by[0]
            right_in = by[1]

This should be right_on = by[1].

Great library btw - I really missed dplyr when moving to python.