search

kiegroup / act-js

A node.js wrapper for nektos/act to programmatically run your github actions locally
Apache License 2.0
53 stars 8 forks source link

feat: added support for passing variables #68

Closed im-sampm closed 6 months ago

im-sampm commented 6 months ago

This change adds basic support for passing --vars to Act.

I chose to model the change on the env implementation rather than event for simplicity, but I feel like vars, env and input could probably be refactored to have a common implementation.

I haven't created test cases for this change.

im-sampm commented 6 months ago

[heart] Sam Peddamatham reacted to your message:

From: Shubh Bapna @.> Sent: Tuesday, January 9, 2024 8:06:11 AM To: kiegroup/act-js @.> Cc: Sam Peddamatham @.>; Author @.> Subject: Re: [kiegroup/act-js] Added support for passing variables (PR #68)

@shubhbapna approved this pull request.

LGTM! Yes I did write the ArgumentMap class to reduce duplicate code between act options like env, matrix, platforms etc but it mainly focuses on having no duplicate code for the toActArguments method. I open to considering better design options!

— Reply to this email directly, view it on GitHubhttps://github.com/kiegroup/act-js/pull/68#pullrequestreview-1810593884, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BBRCVFCHBRUAE5FSHAPOI2DYNT27HAVCNFSM6AAAAABBPDRODOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMJQGU4TGOBYGQ. You are receiving this because you authored the thread.Message ID: @.***>