[DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types

kiegroup / drools-ansible-rulebook-integration

Apache License 2.0

1 stars 9 forks source link

[DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types #114

Closed tkobayas closed 2 weeks ago

tkobayas commented 3 weeks ago

This draft PR requires https://github.com/apache/incubator-kie-drools/pull/6104 to be built beforhand.

Cross repo PR check doesn't work for now.

tkobayas commented 3 weeks ago

@mariofusco With https://github.com/apache/incubator-kie-drools/pull/6104 , now alpha index and node sharing is supported.

Limitation: in case of node sharing, the error message has only one ruleSetName/ruleName/conditionExpression. It means that when a user fixes a condition based on the error message, they may hit the similar issue in another condition next time. It might be invasive to "combine" error messages upon node sharing in drools code base. We may ask Madhu if it's important.

Feel free to share your thought, thanks!

tkobayas commented 3 weeks ago

The point I mentioned at https://github.com/kiegroup/drools-ansible-rulebook-integration/pull/112#discussion_r1778056780 still remains

Alpha index skips unmatched AlphaNodes and jumps to the next sink of the right AlphaNode. That means, when an event doesn't match any AlphaNode because of type mismatch , the custom predicate would not be executed. This is actually the case that users want to read the error message ... "No rule fires, I don't know if constraints are wrong". I think we would need to add the check logic in CompositeObjectSinkAdapter.propagateAssertObject.

I'll need to consider further.

tkobayas commented 2 weeks ago

DO-NOT-MERGE until https://github.com/apache/incubator-kie-drools/pull/6104 will be merged and the commit is synced to kiegroup/drools

rgdoliveira commented 2 weeks ago

DO-NOT-MERGE until apache/incubator-kie-drools#6104 will be merged and the commit is synced to kiegroup/drools

@tkobayas FYI I'm doing the sync in PR https://github.com/kiegroup/drools/pull/80