kiegroup / github-action-build-chain

84 stars 24 forks source link

Add partial-downstream feature or extend full-downstream configuration #112

Closed danielezonca closed 4 years ago

danielezonca commented 4 years ago

I have a big project-dependencies file ( link ) and I need to perform a partial downstream execution up to a certain repo.

In this PR #3248 I had to duplicate part of that file to select only the project I need to build with the full-downstream.

My goal is to be able to import this file and also this other file, have a merged project list, add drools as dependency for kogito-runtimes and builds everything up to kogito-examples considering only repos that are in the dependency hierarchy of kogito-examples

Ginxo commented 4 years ago

@danielezonca thinking about it, this could improve tool capabilities. As you proposed me to add a new input to the flow, what if we add these two new inputs.

So in case you define exclude-children-from: kiegroup/drools it won't take drools children dependencies into consideration (the same for exclude-parents-from but excluding parents. Wdyt @danielezonca ? @almope @mareknovotny any better idea?

danielezonca commented 4 years ago

I'm not sure I can easily obtain what I need in this way because I would like to exclude all children of drools except kogito-runtimes that is the only real downstream path I want to follow. Wdyt?

Ginxo commented 4 years ago

@danielezonca you are right, so I guess

it's a better approach. then you will have to define

exclude-dowstream-projects: |
   kiegroup/jbpm
   kiegroup/optaplanner
   kiegroup/optaplanner-wb
   kiegroup/kie-wb-distributions

^ which are the ones have drools as a dependency. wdyt? not 100% sure

we can do the opposite as you proposed me on the chat to use just-follow-up/downtream-projects

Ginxo commented 4 years ago

@danielezonca proposed a perfect solution, which is be able to specify project-triggering-job, this way you can define a pr flow but changing project triggering the job value. Brilliant!