search

kiegroup / github-action-build-chain

86 stars 24 forks source link

remove node 14 #423

Closed shubhbapna closed 2 months ago

shubhbapna commented 1 year ago

Part fix for #405

We don't have to release a new version since we were anyways building it in node 16

MERGE AFTER:

Ginxo commented 1 year ago

but the tool still working with 14.x, why do we need to make it more restrictive? I mean I understand node14 is going EOL but it does not mean the tool is not compatible with 14.x, right?

shubhbapna commented 1 year ago

Right but we will have to start supporting node 18 which might have some breaking changes for node 14 right? (we faced this when we were supporting node 12, 14, and 16 and had to drop 12 because some features like optional chaining in node 16 didn't work with node 12).

For any new feature won't it be enough to make sure that it works in the currently maintained and stable node versions and not the EOL ones?

@Ginxo

shubhbapna commented 1 year ago

@Ginxo soon the packages that we depend on will also drop support for node 14, 16:

And certain packages like gitlab sdk are only supporting node 18 or up now:

Ginxo commented 1 year ago

ok, please resolve lock conflicts and we will merge. Thanks mate