search

kiegroup / github-action-build-chain

86 stars 24 forks source link

[ISSUE 459] add branch head in checkout summary #460

Closed rgdoliveira closed 1 year ago

rgdoliveira commented 1 year ago

Fixes #459

Note: Please, do not check dist/index.js changes. It is automatically generated.

rgdoliveira commented 1 year ago

Would it be possible to add a test case where branchHead is not empty?

@lampajr Thanks, I've applied your suggestion. Regarding the test we are mocking the results of the git commands (like pull and merge) so I did the same for the head. So I'm not sure if it worth to change the Mock method to return something not empty and just check against this new value.

lampajr commented 1 year ago

@rgdoliveira yeah the test looks like it is just checking if the headSpy is really called, so I agree having a not empty might be not so useful. Will try to find if there is a proper way to test it otherwise looks great to me as it is :)