search

kiegroup / jbpm-form-modeler

jBPM Task Form Modeler
http://www.jboss.org/jbpm
8 stars 60 forks source link

[6.5.x] RHBPMS-4768 - On Change Script Code does not work properly for Short … #137

Closed tsurdilo closed 7 years ago

tsurdilo commented 7 years ago

…Date/Timestamp fields in Form Modeler - adding onSelect event handling

tsurdilo commented 7 years ago

@jsoltes please test this to make sure its ok. I am new to the form modeler code so good testing is needed here :) thanks!

mbiarnes commented 7 years ago

@jsoltes if you checked this pls approve this PR so it can be merged

jsoltes commented 7 years ago

@tsurdilo @mbiarnes after it builds, i will test the binaries, and if it is ok, I will approve.

jsoltes commented 7 years ago

I am afraid this still does not fix the customer requirement. "The alert is not fired if you click on the field or change the date." I think the customer also expects it to be fired not only when clicking on the datepicker icon, but also (or rather) when clicking on different date in the (already opened) datepicker. The attached video explains what I mean. Basically the expectation is, as I understand, to fire the event everytime the date value in the textbox is gonna change.

Screencast_08-18-2017.zip

tsurdilo commented 7 years ago

@jsoltes onSelect should capture the clicks of individual dates inside the opened datepicker. In your video behavior is same as before - if have time mind clearing browser cache and retest? For me this works fine in both master and 6.5.x branches. Thanks.

jsoltes commented 7 years ago

@tsurdilo well I tested it on 7.3.x branch, looks like it doesn't work there (tried it also in incognito mode). But I trust you that it works here and on master and I don't want to postpone it more before it gets merged, so I will approve and test it on the resuting 6.5 build.