search

kiegroup / kie-tooling-store

5 stars 5 forks source link

FAI-419: Score Cards: Write README for VSCode Marketplace #38

Closed manstis closed 3 years ago

manstis commented 3 years ago

See https://issues.redhat.com/browse/FAI-419

manstis commented 3 years ago

@ederign FYI. It cannot be finalised until, presumably, the PMML Editor is first published to NPM.

manstis commented 3 years ago

Thank-you for looking @caponetto. I didn't want to step on toes; so sorry if you was going to do this. Eder asked me to write the README and whilst looking for a place to put it I ended up copying and pasting most of the other stuff too. I've made the updates you requested and updated the dependency versions to 0.8.4 (not released, but neither has the actual pmml-editor been released either). I think, when the editor is ready (there are a number of PRs still to be merged before I'd like it to be published to npm and the PR to integrate it into VSCode is not merged yet either) I will update this PR and check it compiles OK before we move on.. whatever version of kogito-tooling that aligns with we will wait and see.

caponetto commented 3 years ago

That's ok, @manstis! Everything looks good to me, so let's wait for the proper integrations/releases and we can do a final look at this PR. Thank you very much! :)

manstis commented 3 years ago

Hi @caponetto @ederign. The PR for VSCode integration has been merged.

That means this PR can be reviewed (although I suspect we're still waiting for a npm release of kogito-tooling).

manstis commented 3 years ago

Hi @tiagobento @ederign @caponetto.

This PR went a lot smoother than I expected. Great (well other than the changes @tiagobento made to pmml-editor I guess).

What does merge of these PRs mean? Is the PMML editor available in VSCode's Market Place "as if by magic"?

I will blog about the editors availability for tyre kicking when it can be downloaded.

caponetto commented 3 years ago

Hi @manstis,

Congratulations on having the PMML editor extension published! 😃

We have a simple Jenkins job (see this file) to publish the extensions after the release is done here.