search

kiegroup / kie-tooling-store

5 stars 5 forks source link

can not support underline '_' or minus '-' with number in attribute ？!!!! #67

Closed GitHubCuCu closed 3 years ago

GitHubCuCu commented 3 years ago

image

image

GitHubCuCu commented 3 years ago

please help me

manstis commented 3 years ago

Hi, thank-you firstly for trying the editor. All feedback is most welcome.

I suspect we are being overly narrow in our parsing of attribute names in the predicate editor.

What we value most is peoples' opinion of using the text based expression editor for predicates. At the moment its implementation is largely incomplete as we did not want to spend a lot of effort on an area we really wanted feedback.

Whilst the PMML specification for predicates supports arbitrarily complex expressions the most complex we could find "in real life" was much more simple "range checks": i.e. 18 <= age <= 65 and the majority seem even more simple: age >= 18.

Can you provide any examples of the complexity of expression you need supported? It sure would help drive our direction.

manstis commented 3 years ago

See https://issues.redhat.com/browse/FAI-503

GitHubCuCu commented 3 years ago

our feature name like 'mv_3_0_24_1','person_3_0_isee_ml_103','la2_u_n' and 'codemodelcode_17_121'，arbitrarily complex expressions like "codemodelcode_17121 > 2", but now our editor can not support '' in feature name .

GitHubCuCu commented 3 years ago

'-' is also not support too; which separator can use?

GitHubCuCu commented 3 years ago

See https://issues.redhat.com/browse/FAI-503

thx for this, some users want to use the Editor interface to create their SCORECARD PMML model.

May I get how long or when this requirement are fulfilled？

manstis commented 3 years ago

ATM the expression editor only supports the regex [a-zA-Z]+[0-9]* i.e. field or field123 or FIELD etc.

I am working on FAI-503 at the moment; however only because it is a simple fix. General development of the editor is suspended until we get sufficient feedback to warrant the investment of time. Small, simple fixes will no doubt continue but more substantial development would need to be planned and resourced accordingly.

manstis commented 3 years ago

I have submitted a fix for review and merge.

When it becomes available after merge depends on where/how you are using the editor. Can you advise?

VSCode plugin? http://scorecard.new etc.

GitHubCuCu commented 3 years ago

yes, I use VSCode plugin. thx!!!!

manstis commented 3 years ago

OK; @ederign @tiagobento can you please advise the release schedule?

Clearly the PR will need approval and merge first.

GitHubCuCu commented 3 years ago

there is another question：minus '-' with number is also not support? image image

manstis commented 3 years ago

The same fix I submitted should resolve that too.

GitHubCuCu commented 3 years ago

The same fix I submitted should resolve that too.

thx!!!!❤

manstis commented 3 years ago

The issues reported under this issue have all been fixed by https://github.com/kiegroup/kogito-tooling/pull/520