search

kiegroup / kie-tooling-store

5 stars 5 forks source link

VSCode editor replaces characters after BPMN is saved and reopened #74

Open benpattavios opened 3 years ago

benpattavios commented 3 years ago

There seems to be an encoding bug with the VSCode kogito bundle BPMN editor. Notably for us, it has affected ampersand characters in business rules and dash characters in process IDs. There may be other characters affected. To illustrate, take the following simple BPMN: bug-pre-save If I save, close, and reopen the file I get this: bug-post-1-save If I make another minor change, then save, close and reopen the file again I get this: bug-post-2-saves

ederign commented 3 years ago

@benpattavios thanks for reporting this! @romartin or @hasys can you please take a look at this?

romartin commented 3 years ago

Thanks for reporting @benpattavios , and sorry for the inconveniences.

Just reported the issue in our tracking tool, we'll provide updates as soon as possible.

See https://issues.redhat.com/browse/KOGITO-5506

hasys commented 3 years ago

Hi @benpattavios,

process ID should be a valid Java identifier that's why dash replaced by underscore, but with Task name it is a bug for sure. Thank you for reporting!

benpattavios commented 3 years ago

Hi all, thanks for the help!

@hasys That makes sense. Until recently we've only been working with the Business Central editor, which has allowed an dash in our process ID, so there's a bug there, unless that's been changed in a recent update. Maybe some UI feedback would help, like for when you add a duplicate business rule variable- image

hasys commented 3 years ago

Good point, thank you @benpattavios, will add this to the jira issue.