search

kiegroup / mock-github

A library to create a local github environment and easily mock github APIs using an octokit like interface
Apache License 2.0
61 stars 5 forks source link

document Act supported versions #40

Closed Ginxo closed 1 year ago

Ginxo commented 2 years ago

I would recommend to add documentation about the Act supported versions since code like https://github.com/kiegroup/mock-github/blob/41a529b13e91245472239a3a4e315361f2437b3c/src/act/act.ts#L54 would eventually fail depending on the version. I would also recommend to add act_version matrix for https://github.com/kiegroup/mock-github/blob/41a529b13e91245472239a3a4e315361f2437b3c/.github/workflows/pull_request.yml#L16 this way we will assure the tool will still working for supported ones

shubhbapna commented 2 years ago

I haven't tested with older version, so for now I guess I can put the supported version as the latest version.

For act_version matrix I am not sure if that is possible. If you take a look at the action i am using to setup act it uses their install script and it doesn't look like I can specify the version number for to their script.

shubhbapna commented 1 year ago

Not relevent anymore. Check https://github.com/kiegroup/act-js