search

kiegroup / mock-github

A library to create a local github environment and easily mock github APIs using an octokit like interface
Apache License 2.0
61 stars 5 forks source link

typings incorrect in version 2.0.0 #80

Closed tamird closed 10 months ago

tamird commented 10 months ago

In node_modules/@kie/mock-github/build/src/moctokit/moctokit.d.ts I see:

        pulls: {
            ...
            merge: (params?: {
                owner?: string | RegExp | undefined;
                repo?: string | RegExp | undefined;
                pull_number?: number | RegExp | undefined;
                data?: RegExp | undefined;
            } | undefined) => ...
          }
        }

while in version 1.1.0 I see:

            merge: (params?: {
                owner?: string | RegExp | undefined;
                repo?: string | RegExp | undefined;
                pull_number?: number | RegExp | undefined;
                commit_title?: string | RegExp | undefined;
                commit_message?: string | RegExp | undefined;
                sha?: string | RegExp | undefined;
                merge_method?: RegExp | "merge" | "squash" | "rebase" | undefined;
            } | undefined) => ...

I doubt this is the only thing that's wrong, but it is wrong.