[KIEKER-816] Integration of Kieker Data Bridge

rju commented 2 weeks ago

JIRA Issue: KIEKER-816 Integration of Kieker Data Bridge Original Reporter: Reiner Jung

The Kieker Data Bridge (KDB) is an extensible in connector for arbitrary record formats and their mapping to corresponding Kieker IMonitoringRecords.

Goal of this ticket is the integration of the KDB into the Kieker git as tool and its integration in the Kieker distribution.

Checklist:

rju commented 1 week ago

author André van Hoorn -- Thu, 7 Mar 2013 09:33:05 +0100

Reiner Jung: Could you attach your slides to the [agenda page for yesterday's meeting|meeting-20130306], please? The slides contain additional information on this topic (see also KIEKER-856 Done ).

rju commented 1 week ago

author rju -- Thu, 7 Mar 2013 11:17:19 +0100

Slides have been added. See also [^20130306-KDB-and-IDL.pdf:wiki:meeting-20130306 Slides for Kieker Data Bridge and Instrumentation Language]

rju commented 1 week ago

author rju -- Thu, 18 Apr 2013 13:04:22 +0200

The bridge has been transferred to the kieker repository. Presently, it is available in its own branch called bridge. Everyone is invited to evaluate the code and architecture.

Andrè van Hoorn, jwa, nie: To merge the bridge in the main branch, we need your evaluation results on the bridge code.

At the moment the bridge lacks certain features, like support for adaptive monitoring, and some code has to be reimplemented in every connector. However, feature changes should be made in the main branch.

As we all need deadlines, lets say we need a comment on the kdb code for the next kieker meeting.

rju commented 1 week ago

author André van Hoorn -- Thu, 18 Apr 2013 13:39:36 +0200

How about a peer-reviewing session via Connect where you present architecture + code? Would give the chance for immediate feedback and clarification. If so, please suggest dates.

rju commented 1 week ago

author rju -- Thu, 18 Apr 2013 13:49:10 +0200

I guess everyone needs some time to have a look at the code first and the documentation on the bridge should be added as well ( KIEKER-888 Done ). Maybe we could meet at 2nd May 2013 after our meeting with bes at 14:00.

rju commented 1 week ago

author Jan Waller -- Thu, 18 Apr 2013 14:32:51 +0200

I merged the current master into the branch in b1278968b9ba78bf81eb180fe90e5f47bd5fac8f

Compared to master, the following changes were made in the branch:

modified:
```
.classpath
build.xml
```

added:

lib\activemq-core-5.7.0.LICENSE
lib\activemq-core-5.7.0.jar
lib\geronimo-j2ee-management_1.1_spec-1.0.1.LICENSE
lib\geronimo-j2ee-management_1.1_spec-1.0.1.jar
lib\kahadb-5.7.0.LICENSE
lib\kahadb-5.7.0.jar
src\tools\kieker\tools\bridge\IServiceListener.java
src\tools\kieker\tools\bridge\LookupEntity.java
src\tools\kieker\tools\bridge\ServiceContainer.java
src\tools\kieker\tools\bridge\cli\CLIServerMain.java
src\tools\kieker\tools\bridge\connector\IServiceConnector.java
src\tools\kieker\tools\bridge\connector\ServiceConnectorFactory.java
src\tools\kieker\tools\bridge\connector\jms\JMSEmbeddedService.java
src\tools\kieker\tools\bridge\connector\jms\JMSService.java
src\tools\kieker\tools\bridge\connector\tcp\AbstractTCPService.java
src\tools\kieker\tools\bridge\connector\tcp\TCPClientService.java
src\tools\kieker\tools\bridge\connector\tcp\TCPMultiServerService.java
src\tools\kieker\tools\bridge\connector\tcp\TCPSingleServerService.java

rju commented 1 week ago

author Jan Waller -- Thu, 18 Apr 2013 14:40:17 +0200

geronimo-j2ee-management_1.1_spec-1.0.1 is this needed in addition to the already present JavaEE libraries, e.g. Jetty?
lib\activemq-core-5.7.0.LICENSE description is an advertisement copied from the homepage?
same problem with the other descriptions?
activemq-core-5.7.0.jar: don't we already have a JMS library?
kahadb-5.7.0.jar-> derby?

rju commented 1 week ago

author rju -- Thu, 18 Apr 2013 15:32:12 +0200

At present activemq is used in the kieker bridge jms connectors. We might be able to replace it with the JMS configuration from the AsyncJMSWriter. Kahadb is IMHO a dependency for the activemq, but is only used in the JMS connector variant with embedded JMS queue server (which does not work anyhow).

I'll look into it.

rju commented 1 week ago

author Jan Waller -- Thu, 18 Apr 2013 15:34:10 +0200

What I forgot: activemq-core-5.7.0.jar and kahadb-5.7.0.jar are defined as compile time dependencies in the build.xml but are not needed to compile in Eclipse (not included in .classpath).

rju commented 1 week ago

author rju -- Thu, 18 Apr 2013 17:13:20 +0200

In AsyncJMSWriter the connection factory is not hard wired in the code. It uses kieker.monitoring.properties. JMSService and also JMSEmbeddedService can be worked to use similar properties. However, that will result in a change in the constructor design.

However, that may lead to a generic constructor signature, like Service(final Map<Integer, Class<IMonitoringRecord>> recordMap, Configuration configuration).

Would result in changes in the main programs for the bridge as well.

What do you think?

rju commented 1 week ago

author Jan Waller -- Fri, 19 Apr 2013 11:18:54 +0200

I added several (TODO) comments as well as minor changes in e6fd106c21260c7c6062529518ba98d4dd824970
Please take a look at the changes!

General hints:

use final as often as possible -> everything that should not be changed, e.g., by inheritance, should be final.
avoid Exception better to use a subset of it.
take a look at possible problems due to concurrency

I did not yet take a look at the tcp package.

rju commented 1 week ago

author Jan Waller -- Fri, 19 Apr 2013 11:19:51 +0200

Replying to [rju|comment:12]:
> In AsyncJMSWriter the connection factory is not hard wired in the code. It uses kieker.monitoring.properties. JMSService and also JMSEmbeddedService can be worked to use similar properties. However, that will result in a change in the constructor design.
>
> However, that may lead to a generic constructor signature, like Service(final Map<Integer, Class<IMonitoringRecord>> recordMap, Configuration configuration).
>
> Would result in changes in the main programs for the bridge as well.
>
> What do you think?

I think it might be good idea.

rju commented 1 week ago

author André van Hoorn -- Mon, 13 May 2013 11:19:01 +0200

Topic for [next regular meeting on May 16, 2013|Meetings/meeting-20130516/]

rju commented 1 week ago

author rju -- Tue, 3 Sep 2013 10:44:48 +0200

The bridge now has a unified Constructor signature and is configurable via Kieker Configuration.

rju commented 1 week ago

author André van Hoorn -- Tue, 17 Sep 2013 12:40:18 +0200

How is the progress w.r.t. to integration?

rju commented 1 week ago

author rju -- Thu, 19 Sep 2013 18:20:50 +0200

Tests and KDB are ready for merge. We should merge ASAP.

kieker-monitoring / kieker

[KIEKER-816] Integration of Kieker Data Bridge #1077

Checklist: