[KIEKER-812] Correct usage of the CS checks

[rju]

JIRA Issue: KIEKER-812 Correct usage of the CS checks Original Reporter: Nils Christian Ehmke

---

As discussed in KIEK-635:

• The CS checks have to be used only during the ant-build (maybe via another cs-config-file), as they cannot easily be used in Eclipse.
• Findbugs has to know where to find the classes used within the checks.

Checklist:

[rju]

author nils-christian -- Sat, 23 Feb 2013 10:45:25 +0100

The second part has been done in ee90d520280be49d8109f241d173e13d588e82d9. Findbugs doesn't complain anymore.

[rju]

author Jan Waller -- Mon, 11 Mar 2013 09:58:40 +0100

Fix the open PMD issues in CSUtility

[rju]

author nils-christian -- Mon, 11 Mar 2013 11:00:02 +0100

Replying to [jwa|comment:2]:
> Fix the open PMD issues in CSUtility

Should be fixed in 5dd6481b739e110a2bddb47e60e6176417376289.

[rju]

author Jan Waller -- Fri, 15 Mar 2013 10:59:29 +0100

> > I currently can't run CS in Eclipse.
> > {{

{ > > cannot initialize module TreeWalker \- Unable to instantiate kieker.test.common.cs.AnalysisComponentConstructorCheck > > cannot initialize module TreeWalker \- Unable to instantiate kieker.test.common.cs.AnalysisComponentConstructorCheck > > }

}}

Is this one fixed or are the tests disabled, as I can run CS in eclipse now.

[rju]

author nils-christian -- Fri, 15 Mar 2013 11:00:54 +0100

They are all disabled. There are now (I think) four or five tests which should be activated.

[rju]

author Jan Waller -- Wed, 20 Mar 2013 17:56:13 +0100

fixed in e933dff074eb4769efd337885fa81191d567aa4f

[rju]

author nils-christian -- Wed, 20 Mar 2013 18:05:59 +0100

Jan Waller: I think I understand how you did this
- interesting. Mind to explain your approach nevertheless? Just for the sake of documentation (and if someone else has to do this again).

[rju]

author Jan Waller -- Wed, 20 Mar 2013 18:12:01 +0100

Each test has a severity property, if set to ignore, this test is ignored:

<property name="severity" value="${checkstyle.ignoreCustomKieker}" default="ignore"/> 

In this case I made the property configurable. If no configuration is performed, e.g., in Eclipse, the default value of "ignore" is used.

In ant the property gets set, so the tests are executed.

<property key="checkstyle.ignoreCustomKieker" value="error" /> 

It would be easy to use a new property for each test, so each test can have a different severity. Furthermore we should check whether error or info is wanted. warning is currently reserved for todos.