kieker-monitoring / kieker

Kieker's main repository
Apache License 2.0
70 stars 41 forks source link

[KIEKER-110] Exclude certain operations from being exported via JMX #1152

Open rju opened 2 weeks ago

rju commented 2 weeks ago

JIRA Issue: KIEKER-110 Exclude certain operations from being exported via JMX Original Reporter: Andre van Hoorn


Some methods make little sense via JMX --- at least via jconsole.

Examples:
1. ScheduledSamplerJob schedulePeriodicSampler(final ISampler sampler, final long initialDelay, final long period, final TimeUnit timeUnit)
1. removeScheduledSampler(final ScheduledSamplerJob sampler)

At least under Windows, I've seen warnings popping up. However, not sure whether these occurred when connecting to the Monitoring Controller Bean or when trying to invoke these methods.

Questions:

Checklist:

rju commented 1 week ago

author Jan Waller -- Fri, 23 Nov 2012 00:18:23 +0100

Replying to KIEKER-110 Done :
> At least under Windows, I've seen warnings popping up. However, not sure whether these occurred when connecting to the Monitoring Controller Bean or when trying to invoke these methods.

This should be checked.

> Questions:
> * Is there a way to exclude selected methods from being exported via JMX?
> * Do the afore-mentioned methods make any sense for JMX use cases other than using the jconsole?

Yes to both.

rju commented 1 week ago

author Jan Waller -- Mon, 26 Nov 2012 17:35:33 +0100

The following errors are reported:

Error setting Operation panel :kieker.monitoring.core.sampler.ISampler
Error setting Operation panel :kieker.monitoring.core.sampler.ScheduledSamplerJob
Error setting Operation panel :kieker.common.record.IMonitoringRecord

We could certainly exclude some methods from the JMX interface, but I would prefer to keep it complete.

rju commented 1 week ago

author Jan Waller -- Mon, 26 Nov 2012 17:36:05 +0100

A workaround would be adding the kieker.jar to the jconsole classpath.

rju commented 1 week ago

author André van Hoorn -- Mon, 26 Nov 2012 17:54:28 +0100

I agree to keep all operations as part of the exported interface. Some may don't might don't make sense to be used via jconsole. However, there may be other JMX use case where they are useful.

Replying to [jwa|comment:3]:
> A workaround would be adding the kieker.jar to the jconsole classpath.

Right, this would be the appropriate workaround to avoid the warnings.