search

kieker-monitoring / kieker

Kieker's main repository
Apache License 2.0
70 stars 41 forks source link

[KIEKER-992] Replace Kieler-Jar with Maven Dependency #1195

Open rju opened 1 week ago

rju commented 1 week ago

JIRA Issue: KIEKER-992 Replace Kieler-Jar with Maven Dependency Original Reporter: Nils Christian Ehmke

The Kieker-Jar within the lib folder of the WebGUI should be replaced with a Maven dependency. It is not recommended to use libs from the file system within a pom file.

Maybe it is also possible to remove the Kieker-Jar from the resources directory and download it instead during the build process.

See also KIEKER-483 Done .

rju commented 3 days ago

author Jan Waller -- Tue, 16 Oct 2012 20:58:46 +0200

This might be a good idea for releases, but you can't get nightly versions of Kieker this way (in order to implement new features)

rju commented 3 days ago

author André van Hoorn -- Tue, 16 Oct 2012 22:03:18 +0200

As far as I know, we can also upload snapshots, e.g. after each successful build in our Jenkins server.

rju commented 3 days ago

author nils-christian -- Thu, 21 Feb 2013 10:35:28 +0100

I replaced the jar-file in the lib lirectory in changeset:07eb0835dc7dcaaac329521731f24920c8d8a2f8/kieker.webgui.

There is still the jar file in the resources directory though...

rju commented 3 days ago

author nils-christian -- Fri, 15 Mar 2013 11:22:39 +0100

Additional information: Except for the jetty-runner-jar the only remaining jar is the file containing the Kieler Layout Algorithms (klay_0.2.0.jar). As this dependency to so called system files is not recommended, it would be nice to replace this one as well with an actual maven dependency. The last time I checked it was not possible to download klay_0.2.0.jar with Maven though. I sent an email some months ago, but never received an answer. Maybe one could/should talk to them directly...

rju commented 3 days ago

author nils-christian -- Fri, 15 Mar 2013 13:25:21 +0100

avh sent another email. We can expect an answer from one of the developers Christoph Daniel the week after next.

rju commented 3 days ago

author 5bd87e74bae77f4b760f5bf2 unknown Jira user -- Wed, 27 Mar 2013 17:01:48 +0100

Replying to [nie|comment:5]:
> Additional information: Except for the jetty-runner-jar the only remaining jar is the file containing the Kieler Layout Algorithms (klay_0.2.0.jar). As this dependency to so called system files is not recommended, it would be nice to replace this one as well with an actual maven dependency. The last time I checked it was not possible to download klay_0.2.0.jar with Maven though. I sent an email some months ago, but never received an answer. Maybe one could/should talk to them directly...

The KLay layouter library is currently not available through a Maven repository. While I would like it to be, I currently see two issues that you might be able to shed light upon:

1. We publish two versions of the KLay library: the first depends on Eclipse EMF being available while the second contains the required EMF classes. I'm not sure if it is a good idea to provide both through the central Maven repository. I also don't know if the EMF libraries are already available through the repository.

2. I'm having a hard time estimating how much work it would be to get our library published. Do you have any experience that you can share?

By the way, sorry that we obviously failed to reply to your original e-mail. We had some problems with our official support e-mail address a while ago.

rju commented 3 days ago

author nils-christian -- Wed, 3 Apr 2013 14:06:21 +0200

1. Well, technically we do the same. We provide multiple versions of Kieker, e.g. one version with EMF.

2. As we already did this (and have run through the problems), I think we can help with this one (avh can probably explain this a little bit better)

rju commented 3 days ago

author André van Hoorn -- Wed, 3 Apr 2013 14:17:50 +0200

Replying to [nie|comment:9]:
> 1. Well, technically we do the same. We provide multiple versions of Kieker, e.g. one version with EMF.

Right, we provide 3 variants of the Kieker Maven artifact:
1. The "pure" library with external dependencies not being included
2. An AspectJ variant, i.e., the lib from 1. including the AspectJ classes
3. An EMF version, i.e., the lib from 1. including the EMF classes

We use the Maven classifier tag allowing users to choose from either of these variantes of our single artifact. (see, for example, http://kieker-monitoring.net/download/nightly/)

> 2. As we already did this (and have run through the problems), I think we can help with this one (avh can probably explain this a little bit better)

In my opinion, the required steps are document quite well in KIEKER-483 Done .

rju commented 3 days ago

author nils-christian -- Mon, 27 May 2013 18:09:54 +0200

Any news on this? Any chance that there will be a klay maven dependency?

rju commented 3 days ago

author 5bd87e74bae77f4b760f5bf2 unknown Jira user -- Mon, 27 May 2013 20:40:24 +0200

I still have a ticket open on this and the chance of it being taken care of is high. I cannot say when exactly that will be, however, since we currently don't have time to work on this.

rju commented 3 days ago

author nils-christian -- Fri, 25 Oct 2013 13:18:11 +0200

Link to the ticket: http://rtsys.informatik.uni-kiel.de/jira/browse/KIELER-2375

rju commented 3 days ago

author André van Hoorn -- Mon, 18 Nov 2013 15:46:40 +0100

Ticket should be renamed to Kie*l*er, right?

rju commented 3 days ago

author nils-christian -- Thu, 6 Mar 2014 16:57:35 +0100

Still any chance?

rju commented 3 days ago

author 557058:2f86c97e-1656-4688-a808-c4e694bce9da unknown Jira user -- Thu, 6 Mar 2014 17:07:03 +0100

I would still love this to be worked on, but the issue of not having time is persistent. At the present time, I have no idea when we might get around to doing this.