[KIEKER-470] Set experiment ID (in OperationExecutionRecords) deprecated?

rju commented 3 days ago

JIRA Issue: KIEKER-470 Set experiment ID (in OperationExecutionRecords) deprecated? Original Reporter: Andre van Hoorn

Do we have use cases for an experiment ID?
Old (FS) logs should still be supported

rju commented 2 days ago

author André van Hoorn -- Wed, 21 Mar 2012 12:29:48 +0100

The OperationExecutionRecord is definitely the wrong place to store this information.

For 1.5: Marked it deprecated (73e3cff938443377bdffeb830f740f3ee27366c7).
For 1.6:
Remove member, getter, setter
Provide legacy mode for deserializing records (depending on size of input array).

rju commented 2 days ago

author Jan Waller -- Wed, 21 Mar 2012 13:55:39 +0100

In other locations, the experiment Id should be kept? E.g., in the MonitoringController?

rju commented 2 days ago

author André van Hoorn -- Wed, 21 Mar 2012 13:57:46 +0100

Replying to [jwa|comment:2]:
> In other locations, the experiment Id should be kept? E.g., in the MonitoringController?

Yes, I think a concept of having an experiment ID does make sense.

rju commented 2 days ago

author nils-christian -- Wed, 28 Mar 2012 15:15:01 +0200

To be removed in 1.6.

rju commented 2 days ago

author Jan Waller -- Fri, 20 Apr 2012 10:29:51 +0200

Replying to [avh|comment:1]:
> * Provide legacy mode for deserializing records (depending on size of input array).

This is not possible for the binary fs reader.

rju commented 2 days ago

author Jan Waller -- Fri, 20 Apr 2012 11:08:35 +0200

removed everything, but still writes a dummy value, see above, in e962a28d9ebf0827a1b9f202f5f93bdce1b0ecef

rju commented 2 days ago

author Jan Waller -- Thu, 3 May 2012 14:50:25 +0200

2c3d0abb2180d722196f02fc9fc9b6d70e678227

legacy mode for normal FS Reader implemented, all other readers expect the new record format

rju commented 2 days ago

author André van Hoorn -- Thu, 3 May 2012 14:53:22 +0200

Do we have a JUnit test for this legacy mode? Otherwise, chances are good that this legacy mode gets broken in the future

rju commented 2 days ago

author Jan Waller -- Thu, 3 May 2012 15:35:02 +0200

620b18c3b99fda5ac8df0c76ac57be5df8218f9b

Now, we have one...

rju commented 2 days ago

author André van Hoorn -- Tue, 31 Jul 2012 15:59:47 +0200

In changeset:6d53dc83cd5214ef4b110058ad15c2c2fa9d37d1/kieker-git (branch refactor-log-replayers):

Changed the example data in examples/userguide/ch5--trace-monitoring-aspectj/testdata/kieker-20100830-082225522-UTC to the new format:

$ cp kieker-20100830-082225582-UTC-Thread-2.dat kieker-20100830-082225582-UTC-Thread-2.dat.old

$ cat kieker-20100830-082225582-UTC-Thread-2.dat.old | sed s/";0;b"/";b"/g > kieker-20100830-082225582-UTC-Thread-2.dat

$ diff -y kieker-20100830-082225582-UTC-Thread-2.dat.old kieker-20100830-082225582-UTC-Thread-2.dat | head

$0;1283156545581511026;0;bookstoreTracing.Catalog.getBook(boo | $0;1283156545581511026;bookstoreTracing.Catalog.getBook(boole
$0;1283156545582989159;0;bookstoreTracing.Catalog.getBook(boo | $0;1283156545582989159;bookstoreTracing.Catalog.getBook(boole
$0;1283156545583183369;0;bookstoreTracing.Catalog.getBook(boo | $0;1283156545583183369;bookstoreTracing.Catalog.getBook(boole
$0;1283156545583394575;0;bookstoreTracing.Catalog.getBook(boo | $0;1283156545583394575;bookstoreTracing.Catalog.getBook(boole
$0;1283156545584578135;0;bookstoreTracing.Catalog.getBook(boo | $0;1283156545584578135;bookstoreTracing.Catalog.getBook(boole
$0;1283156545584768739;0;bookstoreTracing.Catalog.getBook(boo | $0;1283156545584768739;bookstoreTracing.Catalog.getBook(boole
$0;1283156545584955238;0;bookstoreTracing.Catalog.getBook(boo | $0;1283156545584955238;bookstoreTracing.Catalog.getBook(boole
$0;1283156545585143271;0;bookstoreTracing.Catalog.getBook(boo | $0;1283156545585143271;bookstoreTracing.Catalog.getBook(boole
$0;1283156545585331707;0;bookstoreTracing.Catalog.getBook(boo | $0;1283156545585331707;bookstoreTracing.Catalog.getBook(boole
$0;1283156545585517612;0;bookstoreTracing.Catalog.getBook(boo | $0;1283156545585517612;bookstoreTracing.Catalog.getBook(boole

$ rm kieker-20100830-082225582-UTC-Thread-2.dat.old

$ $ bin/trace-analysis.sh -i examples/userguide/ch5--trace-monitoring-aspectj/testdata/kieker-20100830-082225522-UTC/ --plot-Container-Dependency-Graph -o tmp/
#
# Configuration
--inputdirs: examples/userguide/ch5--trace-monitoring-aspectj/testdata/kieker-20100830-082225522-UTC/
--outputdir: tmp//
--output-filename-prefix: 
--plot-Deployment-Sequence-Diagrams: false
--plot-Assembly-Sequence-Diagrams: false
--plot-Deployment-Component-Dependency-Graph: false
--plot-Assembly-Component-Dependency-Graph: false
--plot-Container-Dependency-Graph: true
--plot-Deployment-Operation-Dependency-Graph: false
--plot-Assembly-Operation-Dependency-Graph: false
--plot-Aggregated-Deployment-Call-Tree: false
--plot-Aggregated-Assembly-Call-Tree: false
--plot-Call-Trees: false
--print-Message-Traces: false
--print-Execution-Traces: false
--print-invalid-Execution-Traces: false
--print-Deployment-Equivalence-Classes: false
--print-Assembly-Equivalence-Classes: false
--select-traces: <select all>
--ignore-invalid-traces: false
--max-trace-duration: 600000 ms
--ignore-executions-before-date: Thu, 1 Jan 1970 00:00:00 +0000 (UTC) (Thu, 1 Jan 1970 01:00:00 +0100 (local time))
--ignore-executions-after-date: Fri, 11 Apr 2262 23:47:16 +0000 (UTC) (Sat, 12 Apr 2262 01:47:16 +0200 (local time))
--short-labels: false
--include-self-loops: false

#
# Plugin: Container dependency graph
Wrote dependency graph to file '/home/voorn/git_work/kieker/tmp/containerDependencyGraph.dot'
Dot file can be converted using the dot tool
Example: dot -T svg /home/voorn/git_work/kieker/tmp/containerDependencyGraph.dot > /home/voorn/git_work/kieker/tmp/containerDependencyGraph.svg

#
# Plugin: 
Wrote HTML output of system model to file '/home/voorn/git_work/kieker/tmp/system-entities.html'

#
# Plugin: Container dependency graph
Trace processing summary: 1635 total; 1635 succeeded; 0 failed.
Saved 1 dependency graph

#
# Plugin: Trace reconstruction (execution records -> execution traces)
Trace processing summary: 1635 total; 1635 succeeded; 0 failed.
First timestamp: 1283156498770302094 (Mon, 30 Aug 2010 08:21:38 +0000 (UTC),Mon, 30 Aug 2010 10:21:38 +0200 (local time))
Last timestamp: 1283156499363031606 (Mon, 30 Aug 2010 08:21:39 +0000 (UTC),Mon, 30 Aug 2010 10:21:39 +0200 (local time))

#
# Plugin: Trace reconstruction (event record traces -> execution traces)
Trace processing summary: 0 total; 0 succeeded; 0 failed.

See 'kieker.log' for details

real    0m1.405s
user    0m2.032s
sys     0m0.112s

kieker-monitoring / kieker

[KIEKER-470] Set experiment ID (in OperationExecutionRecords) deprecated? #1405