search

kieker-monitoring / kieker

Kieker's main repository
Apache License 2.0
70 stars 41 forks source link

[KIEKER-1913] Support default methods #1926

Closed rju closed 1 day ago

rju commented 1 day ago

JIRA Issue: KIEKER-1913 Support default methods Original Reporter: David Georg Reichelt

Default methods of interfaces are currently not handled correctly by the PatternParser. This should be fixed.

rju commented 1 day ago

author rju -- Fri, 17 Dec 2021 11:58:02 +0100

The pattern parser needs a cleanup anyway. As it is a total mess. It can only handle Java signatures, but does not use a Java compatible way of writing them. AspectJ has a much more convincing format. Maybe we should copy that.

rju commented 1 day ago

author DaGeRe -- Fri, 17 Dec 2021 16:34:20 +0100

Basically, I like that the PatternParser currently works for checking whether method should be included or excluded for monitoring. If the Kieker-Patterns would not be supported anymore, this would require a notable effort to work with a different pattern format. Furthermore, I am not sure whether the AspectJ format has the full expression power the pattern parser currently has.

Therefore, I would suggest to start by just getting the PatternParser working for default methods of interfaces and postpone the bigger refactoring.

rju commented 1 day ago

author rju -- Fri, 17 Dec 2021 17:19:34 +0100

For your current effort I think that makes sense. However, down the road, we might have to address the issue again. Also currently, the “grammar” for the patterns is special aka not well documented and not really following typical rules, which makes it hard to add things. Maybe you could at least add this to thesis. aka providing a design before implementation. Also helps to motivate tests.