kieker-monitoring / kieker

Kieker's main repository
Apache License 2.0
70 stars 41 forks source link

[KIEKER-1896] Trace analysis tool: value-less parameters require a value #1943

Open rju opened 2 weeks ago

rju commented 2 weeks ago

JIRA Issue: KIEKER-1896 Trace analysis tool: value-less parameters require a value Original Reporter: Andre van Hoorn


According to our documentation (e.g., https://kieker-monitoring.readthedocs.io/en/latest/kieker-tools/Trace-Analysis-Tool.html#kieker-tools-trace-analysis-tool), this would be an appropriate call to generate dependency graphs:

andrevanhoornAndres-MBP trace-analysis-1.15 % bin/trace-analysis -inputdirs ../../examples/userguide/ch5-trace-monitoring-aspectj/testdata/kieker-20100830-082225522-UTC --outputdir . --plot-Deployment-Operation-Dependency-Graph

However, the execution fails with the following error log:
{{
andrevanhoornAndres-MBP trace-analysis-1.15 % cat kieker.log
16:38:40.052 [main] ERROR k.t.t.analysis.TraceAnalysisToolMain - Expected a value after parameter --plot-Deployment-Operation-Dependency-Graph}}

What works is giving (for instance) 'true' as a value:

{{andrevanhoornAndres-MBP trace-analysis-1.15 % bin/trace-analysis -inputdirs ../../examples/userguide/ch5-trace-monitoring-aspectj/testdata/kieker-20100830-082225522-UTC --outputdir . --plot-Deployment-Operation-Dependency-Graph true
<> 16:39:04.435 [main] INFO k.t.t.analysis.TraceAnalysisToolMain - Ignoring records before 19700101-000000 (0)
<> 16:39:04.438 [main] INFO k.t.t.analysis.TraceAnalysisToolMain - Ignoring records after 2922789940817-071255 (9223372036854775807)
<> 16:39:04.495 [Thread-1] INFO k.a.p.r.filesystem.FSDirectoryReader - < Loading /Users/andrevanhoorn/Downloads/kieker-1.15/examples/userguide/ch5--trace-monitoring-aspectj/testdata/kieker-20100830-082225522-UTC/kieker-20100830-082225582-UTC-Thread-2.dat
<> 16:39:04.497 [Thread-0] INFO kieker.analysis.AnalysisController - Kieker metadata: version='1.9-SNAPSHOT', controllerName='KIEKER', hostname='avh-ThinkPad-RSS', experimentId='1', debugMode='false', timeOffset='0', timeUnit='NANOSECONDS', numberOfRecords='1'
<> 16:39:04.664 [main] INFO kieker.analysis.AnalysisController - Terminating analysis.
<> 16:39:04.664 [main] INFO k.a.p.r.f.FSReader (FSReader-2) - Shutting down reader.
<> 16:39:05.092 [main] INFO k.t.t.analysis.TraceAnalysisToolMain - Saved analysis configuration to file '/Users/andrevanhoorn/Downloads/kieker-1.15/tools/trace-analysis-1.15/traceAnalysis.kax'
<> 16:39:05.096 [main] INFO k.t.t.analysis.TraceAnalysisToolMain - Analysis complete. See 'kieker.log' for details.}}

rju commented 2 weeks ago

author rju -- Wed, 24 May 2023 14:35:55 +0200

I think this is a limitation of the JCommander-API also it is strange to have option -xxx with an optional value. However, this might have been fixed.