search

kieker-monitoring / kieker

Kieker's main repository
Apache License 2.0
70 stars 41 forks source link

[KIEKER-1500] Migrate/Import remaining readers #2337

Open rju opened 4 days ago

rju commented 4 days ago

JIRA Issue: KIEKER-1500 Migrate/Import remaining readers Original Reporter: Lars Blümke

Migrate the readers + tests which have not been migrated so far:

Import the already migrated reader:

Import/Migrate tests for AMQPReader and JMSReader

rju commented 3 days ago

author SoerenHenning -- Thu, 19 Jan 2017 14:23:55 +0100

The file system, network (tcp) and database reader are already migrated. See KIEKER-1506 Closed

rju commented 3 days ago

author Lars Blümke -- Tue, 24 Jan 2017 19:06:17 +0100

Maybe there should be a superclass or interface for readers again. Abstract classes like the AbstractLogReplayer might just use "a reader" without defining which particular reader. However, such a class or interface would probably be empty, because with TeeTime most readers simply extend AbstractProducerStage. What's the best solution?

rju commented 3 days ago

author Lars Blümke -- Wed, 25 Jan 2017 12:15:48 +0100

We decided to use AbstractProducerStage as superclass in such cases.

rju commented 3 days ago

author SoerenHenning -- Wed, 25 Jan 2017 12:34:19 +0100

I think Generics should solve this problem? When a class requires a Reader this would be an AbstractProducerStage<IMonitoringRecord> (or a subclass of IMonitoringRecord).

Or do I misunderstand something?

rju commented 3 days ago

author Lars Blümke -- Wed, 25 Jan 2017 12:53:32 +0100

No that's exactly what I meant, the abstract method from the AbstractLogReplayer looks like this now: protected abstract AbstractProducerStage<IMonitoringRecord> createReader();