rju
commented
1 day ago author André van Hoorn -- Sat, 26 Sep 2015 01:08:58 +0200
How to reproduce:
1. Adding reference to non-existing class into Aspect (in this case OperationExecutionJerseyClientInterceptor)
avhAndrè van Hoorn-ThinkPad-RSS:0:~/git_work/kieker <1.12>* $ git diff
diff --git a/kieker-monitoring/src/kieker/monitoring/probe/aspectj/jersey/OperationExecutionJerseyClientInterceptor.java b/kieker-monitoring/src/kieker/monitoring/probe/aspectj/jersey/OperationExecutionJerseyClientInterceptor.java
index 76667df..977c420 100644
--- a/kieker-monitoring/src/kieker/monitoring/probe/aspectj/jersey/OperationExecutionJerseyClientInterceptor.java
+++ b/kieker-monitoring/src/kieker/monitoring/probe/aspectj/jersey/OperationExecutionJerseyClientInterceptor.java
-71,7 +71,7 public class OperationExecutionJerseyClientInterceptor extends AbstractAspectJPr
*
* return value of the intercepted method
*/
- Around("execution(public com.sun.jersey.api.client.ClientResponse com.sun.jersey.client.apache4.ApacheHttpClient4Handler.handle(com.sun.jersey.api.client.ClientRequest))")
+ Around("execution(public XXcom.sun.jersey.api.client.ClientResponse com.sun.jersey.client.apache4.ApacheHttpClient4Handler.handle(com.sun.jersey.api.client.ClientRequest))")
public Object operation(final ProceedingJoinPoint thisJoinPoint) throws Throwable { // NOCS (Throwable)
if (!CTRLINST.isMonitoringEnabled()) {
return thisJoinPoint.proceed();
2. The warning is displayed during the build:
avhAndrè van Hoorn-ThinkPad-RSS:0:~/git_work/kieker <1.12>* $ gradle distribute -x check -x test
JAR to delete: ArchivePublishArtifact kieker:jar:jar:
:kieker-common:replaceHardCodedVersionNames
:kieker-common:compileJava
warning: [options] bootstrap class path not set in conjunction with -source 1.6
1 warning
:kieker-common:processResources UP-TO-DATE
:kieker-common:classes
:kieker-common:jar
:kieker-analysis:compileJava
warning: [options] bootstrap class path not set in conjunction with -source 1.6
1 warning
:kieker-analysis:processResources UP-TO-DATE
:kieker-analysis:classes
:kieker-analysis:jar
:kieker-analysis:assemble
:kieker-analysis:build
:kieker-common:assemble
:kieker-common:build
:kieker-monitoring:compileJava
warning: [options] bootstrap class path not set in conjunction with -source 1.6
1 warning
[ant:iajc] warning at Around("execution(public XXcom.sun.jersey.api.client.ClientResponse com.sun.jersey.client.apache4.ApacheHttpClient4Handler.handle(com.sun.jersey.api.client.ClientRequest))")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/mnt/sda1/avh-data/kieker/kieker-monitoring/src/kieker/monitoring/probe/aspectj/jersey/OperationExecutionJerseyClientInterceptor.java:74:0::0 no match for this type name: XXcom.sun.jersey.api.client.ClientResponse [Xlint:invalidAbsoluteTypeName]
:kieker-monitoring:processResources
:kieker-monitoring:classes
:kieker-monitoring:jar
:kieker-monitoring:assemble
3. One way to check this could be an extension of the check script. For this, we could, for instance, parse the output of the following Gradle call:
# now build release from source (including checks and tests)
run_gradle distribute
However, I don't have a good idea how to grep the Gradle output, because just adding "| grep ..." would hide gradle's return code and the script might not terminate on a non-zero return code of gradle.
Would be better if you could configure the compiler to abort on such a warning.
JIRA Issue: KIEKER-1366 Extend check script to check for AspectJ compiler warnings Original Reporter: Andre van Hoorn
Example:
[ant:iajc] warning at Around("execution(public com.sun.jersey.api.client.ClientResponse com.sun.jersey.client.apache4.ApacheHttpClient4Handler.handle(com.sun.jersey.api.client.ClientRequest))") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ /home/tp/Tools/kieker/kieker-nightly/kieker-monitoring/src/kieker/monitoring/probe/aspectj/jersey/OperationExecutionJerseyClientInterceptor.java:61:0::0 no match for this type name: com.sun.jersey.client.apache4.ApacheHttpClient4Handler [Xlint:invalidAbsoluteTypeName]Currently, we wouldn't notice such problem (automatically).