[KIEKER-1154] Resolve NOPMD/NOCS without comments

[rju]

JIRA Issue: KIEKER-1154 Resolve NOPMD/NOCS without comments Original Reporter: Andre van Hoorn

---

The code includes a number of // NOPMD and // NOCS statements without reasons:

Examples:

• Good: } catch (final Exception ex) { // NOPMD NOCS (IllegalCatchCheck)
• Bad: } catch (final Exception ex) { // NOPMD NOCS

Current statistics:

1. All NOCSs:

avhAndrè van Hoorn-ThinkPad-RSS:0:~/git_work/kieker <opad-tslib-integration> $ grep -oR "//.*NOCS.*" src/* | wc -l
341
avhAndrè van Hoorn-ThinkPad-RSS:0:~/git_work/kieker <opad-tslib-integration> $ grep -oR "//.*NOCS.*" test/* | wc -l
292

1. NOCSs without comment (assuming them to be given in parentheses)

avhAndrè van Hoorn-ThinkPad-RSS:0:~/git_work/kieker <opad-tslib-integration> $ grep -oR "//.*NOCS.*" src/* | grep -v "(" | wc -l
120
avhAndrè van Hoorn-ThinkPad-RSS:0:~/git_work/kieker <opad-tslib-integration> $ grep -oR "//.*NOCS.*" test/* | grep -v "(" | wc -l
200

[rju]

author nils-christian -- Mon, 7 Jul 2014 15:15:11 +0200

When taking a look at those statements, we should use this opportunity to watch out for rules which have been silenced very often. Related to KIEKER-1269 Done .