[KIEKER-1156] Strange File ref in RBridgeControl

[rju]

JIRA Issue: KIEKER-1156 Strange File ref in RBridgeControl Original Reporter: Imported User 22

---

When creating an instance of RBridgeControl, a directory? name is needed. Also, there's a reference to a non-existing file plotting2.r. This file is missing. Directory reference needed?

   public static RBridgeControl getInstance(final File root) {
        if (null == RBridgeControl.INSTANCE) {

            // TODO make this configurabe?!?
            RBridgeControl.INSTANCE = new RBridgeControl(false);
            RBridgeControl.INSTANCE.e("OPAD_CONTEXT <<- TRUE");
            // TODO: test if this is needed every time
            // TODO outsource this into a packaged text file, declare the
            // functions at runtime
            // TODO use REngine rather? RServe is not needed any more

            INSTANCE.e("setwd('" + root.getAbsolutePath() + "')");
            // RBridgeControl.INSTANCE
            // .e("sink(file = 'rsink.log', append = TRUE, type = c('output', 'message'),split = FALSE)");
            // INSTANCE.e("source('includes.r', local = FALSE, echo = TRUE)");
            INSTANCE.e("source('plotting2.r', local = FALSE, echo = TRUE)");
            INSTANCE.e("initTS");

            // INSTANCE.e("print( getwd() )");
            // INSTANCE.e("source('basic.r', local = FALSE, echo = TRUE)");
            // INSTANCE.e("dprint('from opad') ");
            // INSTANCE.e("source('plotting.r', local = FALSE, echo = TRUE)");
            // INSTANCE.e("source('opad_functions.r', echo = TRUE, verbose = TRUE)");
            // INSTANCE.e("source('plotting.r', echo = TRUE, verbose = TRUE)");
            // INSTANCE.e("library('logging')");
            // INSTANCE.e("initOPADfunctions()");
        }

        return RBridgeControl.INSTANCE;
    }

[rju]

author André van Hoorn -- Wed, 12 Feb 2014 20:03:38 +0100

File references seem to be added by Till. According to Tom, the missing files don't have any impact. Hence, I'd suggest to remove at least the file include. Maybe also the parameter to getInstance.

[rju]

author André van Hoorn -- Thu, 13 Mar 2014 11:14:44 +0100

Missing files to be found in [/ticket/1143#comment:3]

[rju]

author André van Hoorn -- Wed, 25 Jun 2014 15:13:18 +0200

Removed.