search

kieker-monitoring / kieker

Kieker's main repository
Apache License 2.0
70 stars 41 forks source link

[KIEKER-1020] KaxViz cannot handle unknown plugins #2784

Closed rju closed 1 week ago

rju commented 1 week ago

JIRA Issue: KIEKER-1020 KaxViz cannot handle unknown plugins Original Reporter: Nils Christian Ehmke

The current implementation of KaxViz does not support unknown plugins. The tool is, for example, not able to load a kax file containing the MyResponseTimeFilter as said filter is not in the classpath. Internally, KaxViz tries to instantiate an AnalysisController.

Theoretically the tool should be able to load even unknown plugins, as the necessary information for the visualization can be found in the kax file.

rju commented 1 week ago

author nils-christian -- Thu, 18 Jul 2013 15:40:10 +0200

"Simple" solution:

Instead of instantiating an AC, we should use rather AnalysisController.loadFromFile(...) and the resulting instance of MIProject. This method should not instantiate anything and the meta model instance should deliver the necessary information.

rju commented 1 week ago

author Jan Waller -- Mon, 22 Jul 2013 10:08:18 +0200

On a first look, this sounds good.

rju commented 1 week ago

author nils-christian -- Mon, 22 Jul 2013 14:23:59 +0200

The problem should be solved now. I added the modifications in a new branch with 7e2d779dd4950c722624fa8ad41d74858b8d61ff (KaxViz-KIEK-1020). The build of the tool part, however, depends now on org.eclipse.emf.*.jar as well. Is this a problem?

Jan, could you please take a look at the modifications and check whether it still works as desired?

rju commented 1 week ago

author Jan Waller -- Mon, 22 Jul 2013 14:36:49 +0200

Replying to [nie|comment:3]:
> The build of the tool part, however, depends now on org.eclipse.emf.*.jar as well. Is this a problem?

Fine with me. André?

> Jan, could you please take a look at the modifications and check whether it still works as desired?

Looks good. Makes sense to use the meta-model. Merged back.

rju commented 1 week ago

author nils-christian -- Mon, 22 Jul 2013 14:39:23 +0200

Just realized: If the kax file contains no project name, the title of the window is (for example): null (Bookstore-Example.kax). Is this desired?

rju commented 1 week ago

author Jan Waller -- Mon, 22 Jul 2013 14:41:22 +0200

Better than a crash, but maybe we could check for null and provide an empty String instead, or "Unnamed Project" or something.

rju commented 1 week ago

author nils-christian -- Mon, 22 Jul 2013 14:48:00 +0200

Should be solved in 9d1d7b145d3a470d3a325f8c31e03c394aa110f7.

Without project name:
(Bookstore-Example.kax)

With project name:
SomeName (Bookstore-Example.kax)