kieker-monitoring / kieker

Kieker's main repository
Apache License 2.0
70 stars 41 forks source link

[KIEKER-1005] Kieker Bridge JMS TextMessage processing is unsafe #2787

Closed rju closed 1 week ago

rju commented 1 week ago

JIRA Issue: KIEKER-1005 Kieker Bridge JMS TextMessage processing is unsafe Original Reporter: Reiner Jung


In JMSClientConnector.java:92 a text message is split with the appropriate Java function using ; as a separator character. However, string values is this text message can contain a semicolon and in consequence the split will fail.

Therefore, the text message format specification and its accompanying decoding must be extended to support escaping ; or find another way to encode separation of values.

rju commented 1 week ago

author rju -- Wed, 26 Jun 2013 13:26:42 +0200

Pascale: This problem might be solved by Peer's master student.

rju commented 1 week ago

author rju -- Mon, 2 Sep 2013 18:21:59 +0200

The problem only exists for probes with payloads. Not relevant for Milestone 1.8

rju commented 1 week ago

author rju -- Tue, 3 Sep 2013 10:50:51 +0200

This should be solved together with a general new record structure KIEKER-1322 Done .

rju commented 1 week ago

author rju -- Tue, 12 Sep 2017 14:57:40 +0200

This can be fixed with the new ValueDeserializer when we adapt the JMS reader to the new infrastructure.

rju commented 1 week ago

author rju -- Tue, 12 Sep 2017 15:27:15 +0200

We should synchronize this with efforts to move to TeeTime. Otherwise this is duplication of work.

rju commented 1 week ago

author rju -- Wed, 13 Sep 2017 07:38:13 +0200

Fixed. However, branch name was wrong. ( KIEKER-1007 Done instead of KIEKER-1005 Done )

rju commented 1 week ago

author rju -- Wed, 26 Jun 2013 13:26:42 +0200

Pascale: This problem might be solved by Peer's master student.

rju commented 1 week ago

author rju -- Mon, 2 Sep 2013 18:21:59 +0200

The problem only exists for probes with payloads. Not relevant for Milestone 1.8

rju commented 1 week ago

author rju -- Tue, 3 Sep 2013 10:50:51 +0200

This should be solved together with a general new record structure KIEKER-1322 Done .

rju commented 1 week ago

author rju -- Tue, 12 Sep 2017 14:57:40 +0200

This can be fixed with the new ValueDeserializer when we adapt the JMS reader to the new infrastructure.

rju commented 1 week ago

author rju -- Tue, 12 Sep 2017 15:27:15 +0200

We should synchronize this with efforts to move to TeeTime. Otherwise this is duplication of work.

rju commented 1 week ago

author rju -- Wed, 13 Sep 2017 07:38:13 +0200

Fixed. However, branch name was wrong. ( KIEKER-1007 Done instead of KIEKER-1005 Done )

rju commented 1 week ago

author rju -- Wed, 13 Sep 2017 07:39:41 +0200

This fix is a minimal fix inside the old API. After moving to TeeTime, this should be changed again.