[KIEKER-421] Hard-coded Kieker version numbers in KiekerMetadataRecord

rju commented 2 weeks ago

JIRA Issue: https://kieker-monitoring.atlassian.net/browse/KIEKER-421 Original Reporter: avanhoorn

The (outdated) version name "1.9" appears twice in the (generated) record class. Changed it to a hard-coded "1.10" for the release (in fb36c5b11a65f58cf37d81651c66d58ae0e053db). However, the hard-coded version numbers should be replaced by a call to kieker.common.util.Version.getVERSION().

"Patch":

-       public static final String VERSION = "1.9";
+       public static final String VERSION = kieker.common.util.Version.getVERSION();

-               this.version = version == null?"1.9":version;
+               this.version = version == null ? kieker.common.util.Version.getVERSION() : version;

BTW: Why isn't VERSION used in the second occurrence?

Checklist:

JIRA Comments:

557058:b81a6b7f-b4c8-4105-83ac-47b039a57a19 (JIRA username) added a comment on Thu, 16 Oct 2014 12:58:32

At present the Kieker IRL does not support operations as default values of record parameters. The record in question is defined in: records.misc/Misc.irl (package kieker.common.record.misc). The version value is set there to 1.9 in form of a text-string.

To be able to generate a kieker.common.util.Version.getVERSION() entry, we require some special value sources in the IRL.

The second case is an unclever optimization of the generator.

Therefore, I move this ticket to software->irl as it should be addressed in the IRL generator.

557058:b81a6b7f-b4c8-4105-83ac-47b039a57a19 (JIRA username) added a comment on Thu, 16 Oct 2014 13:49:04

Fixed this issue. Will be available via the update site tomorrow.

rju commented 1 week ago

author rju -- Thu, 16 Oct 2014 12:58:32 +0200