search

kieker-monitoring / kieker

Kieker's main repository
Apache License 2.0
70 stars 41 forks source link

[KIEKER-963] Slimmer AnalysisController #716

Open rju opened 1 week ago

rju commented 1 week ago

JIRA Issue: https://kieker-monitoring.atlassian.net/browse/KIEKER-963 Original Reporter: nils-christian

I think this has already been discussed internally. The AnalysisController class has too many lines. What should be done (in my opinion):

Extract the meta model handling. There should be one class which provides methods to

Of course it has to be checked whether this is possible without using the internal fields of the Analysis Controller itself.

It we extract this functionality, the AC can concentrate on its main task. Which is to handle the life cycle of the plugins.

Checklist:

JIRA Comments:

557058:78303123-c689-4415-9945-bb0c79591440 (JIRA username) added a comment on Mon, 18 Mar 2013 16:35:43

sounds good, but definitely 1.8

557058:629db7ce-5cef-419f-82f8-3dcdebf76471 (JIRA username) added a comment on Fri, 10 May 2013 14:18:27

I started with this in a new branch (bug-857). As I thought it was easy to extract most of the static methods, but this is not the case for the methods which assemble the current configuration or load the configuration from a file, as those methods are connected tightly to the AC. The AC has unfortunately to hand over a lot of lists and mappings to the methods from the new helper class.

At least it was easy to remove the dependency to the org.eclipse.emf.* packages from the AC.

557058:629db7ce-5cef-419f-82f8-3dcdebf76471 (JIRA username) added a comment on Sun, 12 May 2013 15:50:49

Technically finished in a6e9a47d108b51de66591851e219c9270a932629 and up to date with master. JUnit tests are still working, manual analysis test seems to work as well. Seems like we have reduced the number of lines within the AC by some hundreds.

Maybe someone could take a look at this, before we merge this back into the master?

557058:78303123-c689-4415-9945-bb0c79591440 (JIRA username) added a comment on Sun, 12 May 2013 16:08:40

seems good on a quick glance.

I am not sure about the package name common, perhaps more something like model?
But feel free to merge.

557058:629db7ce-5cef-419f-82f8-3dcdebf76471 (JIRA username) added a comment on Sun, 12 May 2013 16:37:37

Thanks Jan. I moved the class to the package model, made some slightly modifications for quality reasons, and merged back.

rju commented 5 days ago

author Jan Waller -- Mon, 18 Mar 2013 16:35:43 +0100

sounds good, but definitely 1.8

rju commented 5 days ago

author nils-christian -- Fri, 10 May 2013 14:18:27 +0200

I started with this in a new branch (bug-857). As I thought it was easy to extract most of the static methods, but this is not the case for the methods which assemble the current configuration or load the configuration from a file, as those methods are connected tightly to the AC. The AC has unfortunately to hand over a lot of lists and mappings to the methods from the new helper class.

At least it was easy to remove the dependency to the org.eclipse.emf.* packages from the AC.

rju commented 5 days ago

author nils-christian -- Sun, 12 May 2013 15:50:49 +0200

Technically finished in a6e9a47d108b51de66591851e219c9270a932629 and up to date with master. JUnit tests are still working, manual analysis test seems to work as well. Seems like we have reduced the number of lines within the AC by some hundreds.

Maybe someone could take a look at this, before we merge this back into the master?

rju commented 5 days ago

author Jan Waller -- Sun, 12 May 2013 16:08:40 +0200

seems good on a quick glance.

I am not sure about the package name common, perhaps more something like model?
But feel free to merge.

rju commented 5 days ago

author nils-christian -- Sun, 12 May 2013 16:37:37 +0200

Thanks Jan. I moved the class to the package model, made some slightly modifications for quality reasons, and merged back.