search

kieker-monitoring / kieker

Kieker's main repository
Apache License 2.0
70 stars 41 forks source link

[KIEKER-766] Constructurs not properly displayed in system HTML output #867

Open rju opened 1 week ago

rju commented 1 week ago

JIRA Issue: KIEKER-766 Constructurs not properly displayed in system HTML output Original Reporter: Andre van Hoorn

The "pseudo method name" <init> is not displayed in the HTML output because it would need to be escaped:

1. Screenshot

1. HTML source (excerpt):

<td class="space"><li><a href="#OPERATION-2"><init>(kieker.examples.userguide.ch2bookstore.Catalog):public</a></li></td>

Checklist:

rju commented 6 days ago

author nils-christian -- Tue, 20 May 2014 09:52:37 +0200

scratch that

rju commented 6 days ago

author Jan Waller -- Tue, 20 May 2014 09:54:30 +0200

Maybe instead fix the html output creator in a way that it creates valid html and escapes some chars?

rju commented 6 days ago

author nils-christian -- Tue, 20 May 2014 10:10:10 +0200

Apache Commons Lang should provide a html escape mechanism we could use to filter the relevant output (would just lead to a runtime dependency of the trace analysis to the commons-lang library).

rju commented 6 days ago

author nils-christian -- Tue, 20 May 2014 10:21:56 +0200

Alternative solution:

Use the following code snippet from Stackoverflow.

StringUtils.replaceEach(text,
        new String[]{"&", "<", ">", "\"", "'", "/"},
        new String[]{"&amp;", "&lt;", "&gt;", "&quot;", "&#x27;", "&#x2F;"});

Would be enough for our bug and could be done without additional library. However, this would only replace some of the html characters.

rju commented 6 days ago

author nils-christian -- Tue, 20 May 2014 10:55:03 +0200

It was not only the constructors, but the <NO-RETURN-TYPE> notes as well. Fixed in 1644f91191fdde392859df2528aa9736ddd0461a with a above mentioned solution.

However, this lead me to another bug.