kieker-monitoring / kieker

Kieker's main repository
Apache License 2.0
70 stars 41 forks source link

[KIEKER-937] Basedir in split build.xml files #967

Open rju opened 1 week ago

rju commented 1 week ago

JIRA Issue: KIEKER-937 Basedir in split build.xml files Original Reporter: Jan Waller


Should the basedir not be .. instead of .?

Checklist:

rju commented 4 days ago

author nils-christian -- Tue, 23 Apr 2013 13:45:19 +0200

From https://ant.apache.org/manual/Tasks/import.html:

This snippet however will resolve imported.properties against the basedir of importing.xml, because the basedir of imported.xml is ignored by Ant.

rju commented 4 days ago

author Jan Waller -- Tue, 23 Apr 2013 13:46:33 +0200

So we could remove the basedir entry altogether?

rju commented 4 days ago

author Jan Waller -- Tue, 23 Apr 2013 14:02:05 +0200

I removed the basedir entry in 2d4b0231eeef3c66bb899cce1a3b7741b3bfdabc

see also KIEKER-936 Done

rju commented 4 days ago

author nils-christian -- Tue, 23 Apr 2013 14:07:08 +0200

Okay. Fixed?

rju commented 4 days ago

author Jan Waller -- Tue, 23 Apr 2013 14:08:45 +0200

KIEKER-936 Done is not fixed by this

It might be even better to include .. as an actually ignored basedir to fool eclipse

rju commented 4 days ago

author nils-christian -- Sat, 27 Apr 2013 11:43:23 +0200

Replying to [jwa|comment:5]:
> KIEKER-936 Done is not fixed by this
>
> It might be even better to include .. as an actually ignored basedir to fool eclipse

That doesn't seem to fool my Eclipse.

rju commented 4 days ago

author nils-christian -- Tue, 11 Jun 2013 13:22:49 +0200

Solved in 17a1b5573db2a52d488520ecc66a72ba6b52cc1c.