search

kieler / elkjs

ELK's layout algorithms for JavaScript
Other
1.81k stars 97 forks source link

Remove DisCo from transpilation to elkjs because it somehow breaks the CI build #288

Closed Eddykasp closed 4 months ago

Eddykasp commented 4 months ago

this confirms that the problem appears to be limited to disco and its CompactionStrategy

soerendomroes commented 4 months ago

Does this mean we remove disco? Or that disco just cannot be transpiled to JavaScript?

Eddykasp commented 4 months ago

Removing it would fix the CI build on Github but since I can still build it locally, I don't think we should jump straight to removing it completely. But it's an option to keep in mind I guess

Eddykasp commented 4 months ago

If I keep re-running the failed runs, eventually they succeed https://github.com/kieler/elkjs/actions/runs/9761341512