search

kieler / klayjs-d3

Bridge for KLayJS and D3.js
Eclipse Public License 1.0
61 stars 8 forks source link

Any plans to make klayjs-d3 compatible with d3-v4? #13

Open rcoaguila opened 7 years ago

rcoaguila commented 7 years ago

Hi, I would like to use this library but my project uses d3-v4. I saw in issue #11 that the version was fixed to ^3.5.0, are there any plans to make it compatible with v4? Or can you provide me some pointers to make this change?

Thanks!

uruuru commented 7 years ago

Yes. Although I don't know when I find time for it. Currently the klayjs-d3 script assumes that the d3 object exists and calls its rebind method. With v4 one has to properly import the d3 object I guess.

AnthonyDry commented 7 years ago

I where able quite easily to use klay-3d with v4 the only big changes is that on the dispatch events you need to us call instead of just using the finish event. as this dispatch.call('finish', foo). I have a working fork over here. https://github.com/AnthonyDry/klayjs-d3/tree/fixesForD3V4

Im terrible att pull-request and Im not sure how the ww should work, so it might be better if someone else do a proper rewrite later.

Best regards!

chandusekhar commented 7 years ago

Is there any place to find klayjs source code to fix it. Complete javascript not build one.

uruuru commented 7 years ago

klayjs is based on Java code, not Javascript. See #16 for the Java source and its documentation for reasons why we do not provide new builds at the moment.