search

kieler / klighd-vscode

Eclipse Public License 2.0
8 stars 6 forks source link

Allow moving node to before 0 when interacting #120

Open kasbah opened 1 year ago

kasbah commented 1 year ago

I was wondering whether you agreed it would be worth trying to implement an interaction which allows setting layerChoiceConstraint to one lower than 0. It could possibly be implemented by adding one to all other layerChoiceConstraint and setting this one to 0. What do you think?

NiklasRentzCAU commented 1 year ago

In general that would be worth implementing to allow for a symmetrical handling of the left and right edge of layer constraints visually. This feature was first implemented in a bachelor's thesis by Connor Schönberner, its section 5.5.2 goes into detail about that, see https://rtsys.informatik.uni-kiel.de/~biblio/downloads/theses/cos-bt.pdf (german only)

@soerendomroes advised this thesis and put in some work to include the interactive layout in this project. Maybe he can give some more insight.

soerendomroes commented 1 year ago

I will have a look at this once I will add the relative constraints that we hid somewhere. I remember that the first implemention needed an explicit nothing value (currently -1) for a primitive data type.

kasbah commented 1 year ago

Great thanks, I speak German so will read the thesis first of all.