kieler / klighd-vscode

Eclipse Public License 2.0
8 stars 6 forks source link

Dark theme support #159

Open NiklasRentzCAU opened 8 months ago

NiklasRentzCAU commented 8 months ago

Implements support for dark / other color themes for clients over the LSP and adds a property to be read by syntheses to conform to some theme-related foreground/background/highlighting colors.

Relates to kieler/KLighD#175

NiklasRentzCAU commented 8 months ago

Some yet-to-dos:

a-sr commented 8 months ago

Regarding todo no. 2, I think there is also a preference in the klighd view that enforces a white background, in this case it woun't make much sense to activate/send color preferences for a dark theme, or do you mean this by no. 2?

NiklasRentzCAU commented 8 months ago

Regarding todo no. 2, I think there is also a preference in the klighd view that enforces a white background, in this case it woun't make much sense to activate/send color preferences for a dark theme, or do you mean this by no. 2?

Haven't thought it through yet, but I would like to make this more automatic and consistent. For this example, if a white background is enforced, then sending no color preferences could be a good idea to allow to show the synthesis-default color theme with this option and to use the theme only in the other cases.