search

kieler / klighd-vscode

Eclipse Public License 2.0
8 stars 6 forks source link

Small bug-fix to successfully run 'yarn package' #31

Closed CheckerFlow closed 1 year ago

CheckerFlow commented 2 years ago

I tried to generate the packages by running 'yarn package' but got an error. Fixed the error by removing some presumably unnecessary quotes.

NiklasRentzCAU commented 2 years ago

On my system (Linux) the command as it is currently will write exports.VERSION = "0.2.1"; to the versions.js file whereas your change will cause it to error and write exports.VERSION = ""$npm_package_version""; to the same file. What OS and yarn version are you using?

The GH actions build being green is not to be trusted here, as it does not package the project, it only builds it.

NiklasRentzCAU commented 1 year ago

Fixed by #131