search

kieler / klighd-vscode

Eclipse Public License 2.0
8 stars 6 forks source link

Calculate absolute coordinates on server and store directly in sknodes #82

Closed Eddykasp closed 1 year ago

Eddykasp commented 2 years ago

Several features, such as incremental diagram generation, to an extent the depth map and the future proxy-view require the absolute coordinates of nodes and compute them independently. This redundancy should be extracted and centralized, possibly to the language server.

NiklasRentzCAU commented 2 years ago

As we tried to off-load several parts of the diagram generation to the client to reduce the necessary amount of data sent during communication (which still is a bigger part of the generation time) I think the centralization could also be on the client side. What about the depth map, can't that be used as a central point for that? Maybe that class just needs a rename to better reflect what it does.

Eddykasp commented 2 years ago

Yes I think the depth map would be a good place to put this stuff, although for the incremental diagram generation this would be too late. Currently there is no implementation of the piece requesting strategy which actually uses precise coordinates though. It's just something to keep in mind.

Eddykasp commented 2 years ago

If we do decide to centralize this responsibility onto the depth map we also need to consider this issue.