kieler / klighd-vscode

Eclipse Public License 2.0
8 stars 6 forks source link

Node titles scaled up with smart zoom with suppressed selection do not suppress correctly #85

Closed NiklasRentzCAU closed 1 year ago

NiklasRentzCAU commented 2 years ago

Renderings such as node titles without smart zoom and with suppressed selection allow to activate actions of renderings that are directly behind that rendering (e.g. region names in SCCharts). When smart zoom decides to scale up said rendering, it places it at a different spot in the SVG (to make sure it will not be overlaid by other rendering parts), which causes action handling in the rendering with suppressed selection to not be forwarded to the rendering directly behind the rendering (i.e. the controlflow rectangle's element), but the parent rendering of the SVG structure (i.e. the node's element) where the action execution does not expect the rendering to be and fails.

The action handler needs to be aware of this change to fix this issue.

NiklasRentzCAU commented 1 year ago

Fixed with #93.