search

kieler / osgiviz

Visualization of OSGi projects using KIELER Lightweight Diagrams (KlighD)
Eclipse Public License 2.0
9 stars 4 forks source link

Model generator added #1

Closed niratschi closed 4 years ago

NiklasRentzCAU commented 4 years ago

Before merging this I found two major points:

  1. The target folder and any code generated by the build should not be included in the version control, please remove that.
  2. For including this into our build process I have some questions on how users should integrate this. As I understand it this is a Maven Mojo that should not be included in a user's Eclipse installation but rather in the pom file of the project for that the model should be generated. How will the user be able to get this mojo other than building the project manually and putting the .jar into their local maven repository? I could add this bundle to be built and included in the updatesite (the osgiviz site here but can users include that into their build and use it then? This is important to know before including this bundle in this project.

Another interesting feature for the future would be to also make an installable plug-in on this code base that allows the user to generate a model from a running Eclipse application with the features and bundles currently installed and used in that installation. But that is just as a note for feature work on this bundle.

NiklasRentzCAU commented 4 years ago

And the copyright headers in all source files need to be changed to refer to the EPL that used in this project. I did not include headers in the other files in this project either yet, but they should look similar to the file headers in similar projects such as debukviz