search

kien-ht / cypress-image-diff-html-report

A HTML reporting module for Cypress-Image-Diff to parse the JSON output into a beautiful report
MIT License
18 stars 1 forks source link

--inlineAssets creates invalid base64 images #7

Closed MoritzMeinhardt closed 3 months ago

MoritzMeinhardt commented 3 months ago

Hi together,

When using the --inlineAssets option the images are base64 encoded. Unfortunately they can not be shown because there is some kind of version added to the end of it.

data:image/png;base64,[removed-image-data]?v=1712433107782

The version is also added when not using --inlineAssets, but then it is not an issue. image

MoritzMeinhardt commented 3 months ago

I guess it was introduced with this change: https://github.com/kien-ht/cypress-image-diff-html-report/commit/70209dcda404573d9de9e6900f17308d319cd230#diff-0a0478ad0f8c8e35491841ae5e25e0636dd7082d6d5c673456afaeb43175cb23R57

MoritzMeinhardt commented 3 months ago

I moved to version 1.4.0 before this change. Now I get the inlined images in the overview. That's nice. But the detail images are not working, they also have that version postfix.

github-actions[bot] commented 3 months ago

:tada: This issue has been resolved in version 2.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

MoritzMeinhardt commented 3 months ago

Thanks a lot for this fast fix!