search

kieran-mackle / AutoTrader

A Python-based development platform for automated trading systems - from backtesting to optimisation to livetrading.
https://kieran-mackle.github.io/AutoTrader/
GNU General Public License v3.0
937 stars 216 forks source link

Fixed bokeh version conflict with panel lib #95

Closed joas77 closed 5 months ago

joas77 commented 6 months ago

boked lib version was outdated

kieran-mackle commented 6 months ago

Hi @joas77, from a quick check, there are some breaking changes between the current and suggested version of Bokeh. The first error to come up was: AttributeError: unexpected attribute 'plot_width' to figure, similar attributes are outer_width, width or min_width.

Please update your branch to fix this if you'd like to continue with the PR. I'll probably tackle this soon myself otherwise.

joas77 commented 5 months ago

Do you have an example of how to hit that error? I've not been able to get that exception. I'm starting with Autotrader so I'm not very familiar with it

kieran-mackle commented 5 months ago

Sorry, I've come back to this a bit late - I've updated the versions in the latest PR to main. Not sure why you weren't hitting those exceptions - I was getting them everywhere a figure was created.

Will close this PR now - thanks for bringing this up.