search

kieran / barista

A URL router / generator for NodeJS
https://kieran.github.io/barista/
MIT License
111 stars 22 forks source link

coffee-script as a devDependency + prepublish #9

Closed JeanSebTr closed 11 years ago

JeanSebTr commented 11 years ago

Hi,

as it's suggested in the npm documentation ( https://npmjs.org/doc/scripts.html ), it would be nice if coffee-script wasn't mandatory with the npm release. Same thing for mocha.

Also, I see you're using a Makefile. I'm not very opinionated about that, but theses tasks could as well be put in the package.json's scripts section.

What do you think ? I would send a pull request if you're ok with that.

Do you have plan to release the coffe-script version soon ? I have a feature I would like to suggest and implement directly in the coffe-script version.

kieran commented 11 years ago

Sweet!

I was planning to push just a compiled version to npm when the conversion was done, but with your PR I don't see why I can't just push it all :-)

I'm just in the middle of rewriting the route definition parser to support nested optional segments, but I keep getting distracted by work and such. The plan is to publish the next release when that's done and a few more mocha tests are migrated / written.

What did you have in mind?

JeanSebTr commented 11 years ago

I had in mind exactly what I remembered have seen in the code and it was indeed there! I just found it again after posting.

The extra_params of a route https://github.com/kieran/barista/blob/master/lib/route.coffee#L193 I'll need to find something else to contribute! :)

kieran commented 11 years ago

I'm sure you'll find plenty more :-)