search

kieranhj / pop-beeb

Prince of Persia port to BBC Master
46 stars 3 forks source link

Enable Music/sound/volume related keys in title sequences #198

Closed simondotm closed 6 years ago

simondotm commented 6 years ago

At the moment pressing any key during intro/attract will exit to game. Not sure if the music/sound/volume key detection code runs during the titles, but it would be nice to be able to adjust volume or turn music on/off in title screens without triggering a game load.

kieranhj commented 6 years ago

There are a few places the keys are checked because could be in a cutscene but I'll take a quick look later on.

kieranhj commented 6 years ago

Couple of challenges - the key detection code just immediately breaks out and calls "start game" in the various places it is used. Also, because the frame buffer alignment is different in attract, we'd need separate fns to write messages to the screen.

kieranhj commented 6 years ago

Hmmm, in theory MUSICKEYS fn in specialk.asm is supposed to handle keyboard input whilst music is playing but might not catch all cases.

simondotm commented 6 years ago

I saw that function, I suspect it needs looking at because we mute the psg in the other check for ksound and kmusic toggles, but not here.

kieranhj commented 6 years ago

The music on/off key combo does work here during attract (but has the psg hangover) but not volume.

kieranhj commented 6 years ago

Fix this so on/off & volume work in cutscenes. Only place it doesn't work is the demo level.