search

kieranhj / pop-beeb

Prince of Persia port to BBC Master
45 stars 2 forks source link

No sound effects play in the attract mode game demo #79

Closed simondotm closed 6 years ago

simondotm commented 6 years ago

Not sure yet if this is a bug or by design...

kieranhj commented 6 years ago

Just watched the demo level in AppleWin and there is definitely supposed to be sound. I do get a sound when the player dies on the spikes on the current Beeb build but nothing else.

simondotm commented 6 years ago

Very strange, I wonder why there's no sound triggering then...

kieranhj commented 6 years ago

Fixed this in demo branch. When an audio bank is loaded it kills the music player. Sound effects rely on the music player being active to update. Enabling the music player after bank load fixes this partially - when ending music early the vgm player didn't set the ended flag in deinit so could still pick up garbage data. Now sorted and fixes a couple of other bugs as well I think.

kieranhj commented 6 years ago

PR'd.