kieranhj / pop-beeb

Prince of Persia port to BBC Master
45 stars 2 forks source link

Make the screen flash effects change BG or FG only? #83

Closed simondotm closed 6 years ago

simondotm commented 6 years ago

Effect might be nicer if only BG/Black colour is flashed. Eg. for health hit, just the BG changing red instead of whole palette? Eg. for cut scene, just the FG changing white instead of whole palette?

kieranhj commented 6 years ago

This is as it works in the Apple II version - do you think it is a bit much?

simondotm commented 6 years ago

Its not bad per se, but would just be a bit of polish I think if only the BG or FG get flashed.

kieranhj commented 6 years ago

The beginning cutscene scene is supposed to flash 5 times (lightning) but just seems to stay solid.

kieranhj commented 6 years ago

Fixed lighting flash.

A modern game would have a photosensitivity warning at the start. Could do this in MODE 7 during load?

kieranhj commented 6 years ago

I added bg only flash for when the weightless potion ends (flashes bg green.) Trivial to change for the other FX. Just need to make a call...

kieranhj commented 6 years ago

Might check the PC version actually as defacto.

kieranhj commented 6 years ago

PC version just flashes background. I will change it to that when I get chance.

kieranhj commented 6 years ago

Fixed.