Implement validation copy using unique codes

[Lionqueen94]

Closes #136 Closes #85 Closes #86 Closes #185 Closes #150 Closes #151 Closes #186

• [x] Implement changed rules in backend and frontend
• [x] Implement validation copy using unique codes
• [x] Update Feedback component to be able to show multiple errors/warnings and correct action list
• [x] Update Feedback component to match design
• [x] Added W.203 in backend (6cd640099bbb3b6ed32f065f8d47312e7505b16d)
• [x] Added W.204 in backend (6cd640099bbb3b6ed32f065f8d47312e7505b16d)
• [x] Added W.205 in backend (ed9c563a950bc5a3aa40446a795c92c10085542c)
• [x] Added W.206 in backend (9586120efd757fb955c36540135c22ad624a3f98)
• [x] Added W.207 in backend (9586120efd757fb955c36540135c22ad624a3f98)
• [x] Added W.208 in backend (9586120efd757fb955c36540135c22ad624a3f98)
• [x] Added sorting of errors and warnings in backend (22af73923680f9a1fc8646173d28c00c260b8604)
• [x] Improved styling of code in Feedback component (4b39beac03f0d6efee86ec32a73f037cad42cf97)
• [x] Set number of eligible voters on PollingStation 34 to 1000 to be able to test the related warnings
• [x] Implemented changes in https://github.com/kiesraad/abacus-internal/pull/223
• [x] Added tests for W.203-207 in frontend
• [x] Improve d2d tests
• [x] Add links to flowchart doc
• [x] Implement test for F.204 or check if this has been done with the right behaviour
• [x] Duplicate errors and warnings in the frontend https://github.com/kiesraad/abacus/pull/266#pullrequestreview-2277820922 (5195bc56aae21ce38dd796e8e574c3216a181fa2)

[jorisleker]

@Lionqueen94 Ik ben ze allemaal langsgelopen. Zie hieronder. Alles met een unchecked checkbox werkte nog niet

Fouten

• [x] Meerdere op 1 pagina
  • [x] Het zou iets eleganter zijn de fouten te sorteren op nummer/code. (F.201 voor F.202 ipv andersom)
• [x] F101
• [x] F.201
• [x] F.202
• [x] F.203
• [ ] F.204 (stemmen op kandidaten = som van uitgebrachte stemmen) Deze zie ik nog niet, hoe kan ik 'm testen?
• [ ] F.301 (Controleer I (stembiljetten meer geteld)) Deze verschijnt meteen bij het openen van de pagina 'verschillen', ipv na het submitten
• [x] F.302
• [ ] F.303 (Controleer J (stembiljetten minder geteld)) Deze verschijnt meteen bij het openen van de de pagina 'verschillen', ipv na het submitten
• [x] F.304
• [x] F.305
• [x] F.401

Waarschuwingen

• [x] Meerdere waarschuwingen op 1 pagina
• [x] W.201
• [x] W.202
• [ ] W.203 Zie ik nog niet (200 kiezers ingevuld, 100 uitgebrachte stemmen)
• [ ] W.204 Zie ik nog niet (200 hertelde kiezers ingevuld, 100 uitgebrachte stemmen)
• [ ] W.205 Zie ik nog niet (0 uitgebrachte stemmen ingevuld)
• [ ] W.206 Aantal kiesgerechtigden is nog niet in te vullen, dus niet kunnen testen
• [ ] W.207 Aantal kiesgerechtigden is nog niet in te vullen, dus niet kunnen testen
• [ ] W.208 Aantal kiesgerechtigden is nog niet in te vullen, dus niet kunnen testen
• [x] W.209
• [x] W.210
• [x] W.301
• [x] W.302

[praseodym]

Most of the unchecked ones are not implemented yet because they are to be done in other issues that are part of #99.

[Lionqueen94]

@jorisleker Thanks a lot for testing everything! Have I implemented the multiple errors/warnings at once design well also? What @praseodym says is correct, the plausibility checks in the W range still will be implemented in this epic. F.204, F.301 and F.303 should be fixed after https://github.com/kiesraad/abacus/pull/233 will be merged.

[jorisleker]

@Lionqueen94 Yes, multiple errors on 1 page is implemented according to design, however, it would be nicer to sort the errors/warnings based on their code (saw a case where F.202 was shown before F.201)

Wasn't completely sure which warnings/errors to test, so just tested all of them :-)

[Lionqueen94]

@jorisleker F.201-F.203 should be in order now, and these should have been the only ones that potentially were out of order. Please let me know if there are any other issues with ordering if you see them.

[Lionqueen94]

@jorisleker I have added the remaining plausibility checks, you can test W.206-208 on stembureau 34, which now has 50 kiesgerechtigden in the database.

[jorisleker]

@Lionqueen94, tested the rules you added:

• [x] Order of warnings when there are multiple is ok now for W.201 & 202

• [ ] Order of warnings still wrong in various cases, ie A 200, D 200, E 100, H 100 -> W.207, W.206, W.203 (one example, seen multiple others with the 200 range.

• [x] W.203

• [x] W.204

• [ ] W.205 is shown immediately when I open /numbers, should be after submit.

• [x] W.206

• [x] W.207

• [x] W.208

• [ ] It's hard to come up with case where W.206 and W.207/W.208 are not triggered at the same time (because toegelaten kiezers and uitgebrachte stemmen should not differ that much). I think it will be better to combine these two checks into one rule. (tested stembureau 34 with A, D, E & H set to 100)

• [ ] Small design issue: the warning code needs a bit more padding on the left side (1.5rem should be fine), and it should top-align with the text of the warning, even if that wraps over multiple lines:

[jschuurk-kr]

@Lionqueen94 Can you update the d2d tests for displaying an error / a warning on the Voters and Votes page to be a more specific now that we have the design fully implemented?

We might also want to add some more d2d tests for errors/warnings, but that makes more sense to do in #233, so we can take navigation etc into account.

[jorisleker]

We might also want to add some more d2d tests for errors/warnings, but that makes more sense to do in #233, so we can take navigation etc into account.

Let's not add more work to #233. After 233 has been merged, it makes sense to add these tests here.

[jschuurk-kr]

We might also want to add some more d2d tests for errors/warnings, but that makes more sense to do in #233, so we can take navigation etc into account.

Let's not add more work to #233. After 233 has been merged, it makes sense to add these tests here.

233 should contain the tests that cover the changes of #233, but agreed that anything more should get a separate issue.

[Lionqueen94]

@jorisleker Can you review again and check the issues that are now fixed in your previous comments? The errors/warnings showing too early should be fixed once Les' PR is merged, but I'll test it then to confirm.

[jorisleker]

Re-tested

• [x] Fixed Order of warnings still wrong in various cases, ie A 200, D 200, E 100, H 100 -> W.207, W.206, W.203 (one example, seen multiple others with the 200 range.
• [x] Fixed It's hard to come up with case where W.206 and W.207/W.208 are not triggered at the same time (because toegelaten kiezers and uitgebrachte stemmen should not differ that much). I think it will be better to combine these two checks into one rule. (tested stembureau 34 with A, D, E & H set to 100)
• [x] Fixed: Small design issue: the warning code needs a bit more padding on the left side (1.5rem should be fine), and it should top-align with the text of the warning, even if that wraps over multiple lines:

New issue:

• [x] W.206 is always shown, no matter which numbers I enter. Can't get it to go away. It is shown immediately when I load /numbers for a polling station with number of kiesgerechtigden filled in. It is not shown if number of kiesgerechtigden is not filled in. Fields D and/or H are only hightlighted when they are actually higher then the number of kiesgerechtigden

[Lionqueen94]

New issue:

* [ ]  W.206 is always shown, no matter which numbers I enter. Can't get it to go away. It is shown immediately when I load `/numbers` for a polling station with number of kiesgerechtigden filled in. It is not shown if number of kiesgerechtigden is not filled in. Fields D and/or H are only hightlighted when they are actually higher then the number of kiesgerechtigden

This is fixed in 106b7bc6f1a4ab707162fae7e43b49603e870a4d

[praseodym]

I removed 164e034 from this PR because it was already merged as part of #281. @Lionqueen94 please make sure not to include that commit when you update this branch.

[praseodym]

Resolved merge conflict.